From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF49C433F5 for ; Fri, 25 Mar 2022 16:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359620AbiCYQBe (ORCPT ); Fri, 25 Mar 2022 12:01:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358061AbiCYQB2 (ORCPT ); Fri, 25 Mar 2022 12:01:28 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 159DC583B3 for ; Fri, 25 Mar 2022 08:59:53 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id b130so5355518pga.13 for ; Fri, 25 Mar 2022 08:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Jbwom5SIfVz2t3Itg2pHeOR73ypDeLXyJJwPCqRaeV4=; b=fSgSIJEw8LXAH0vR2BDKGHY9QcSoC70ZJdOaT8shmp236orB0hEICzqO2IastwqHH9 excwaFADB+juHbEny3EQyDCWc7rHzFxuK840EPYGLLPBalYCP6e2NQJBRAmhM00Wxn9R GLdY51KhDPQePVarSJVUnuq3FtueA3hdjn29nngMLOA6eYWaE/Ub17hidrCY6w7VltJG QF4z6fWrsX5B2FwlA45Zi7xNbI9PohCNv9pxW82OGWh/8TMPuQFNNaUcGf2uEx1kHA+A 1EAkv0zfhieTQ0u4vzKIOvUjbAaXdbHm5wPG8093xTKGobrH2mr1kZIxGmMfe77NPMVA pB1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jbwom5SIfVz2t3Itg2pHeOR73ypDeLXyJJwPCqRaeV4=; b=KspRluQUDxBRZPg8b1kpJTQX9D8TeShNkH1gnMawpdh9ynq+JGeT6yArPLgOli+XQ5 aMhIeXObXrCLRvyGXNBYTUcvv1r509HQetrj82YTSBMRONell8YR6BbVtIkYJSQIUQL9 cR1u0zHcKDoixfFgD2NKVJG2deBem8RtN439JUlOqpFwI4O2dtbq54YY0H4hjU8ssbWj LApQ21ZrkV23EBIEA8mcR+vSdcxCszvDDRWG5RBzB6qQI5Xxxn9wo+x/knHSy6A9uKqf aQXRucwgMH5vU6g46IShXjAzpWtd0KWOu3Qt6mNRdh0OQPCzHJmQCRWJabsKIYI7kNmG Bu5w== X-Gm-Message-State: AOAM5305gbu+wbIkixrjkYkwBkfl38Nf+4mPvcsmpHE8Kw1UHkiCa60F /dzobjK0LChZQdwiqq4z6RA+8g== X-Google-Smtp-Source: ABdhPJwvrLFuQMKm+9L94zZqosStlskB9ebpFokhMd8iQ/vYsFDKdzJXkQaRNdxrSfgLvC3IGvoiDw== X-Received: by 2002:a65:6d87:0:b0:374:2525:dcb0 with SMTP id bc7-20020a656d87000000b003742525dcb0mr234315pgb.248.1648223993163; Fri, 25 Mar 2022 08:59:53 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x2-20020a63aa42000000b0038265eb2495sm5724454pgo.88.2022.03.25.08.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 08:59:52 -0700 (PDT) Date: Fri, 25 Mar 2022 09:59:49 -0600 From: Mathieu Poirier To: Arnaud POULIQUEN Cc: Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, julien.massot@iot.bzh Subject: Re: [PATCH v9 00/11] Restructure the rpmsg_char driver and introduce rpmsg_ctrl driver Message-ID: <20220325155949.GA3576184@p14s> References: <20220124102524.295783-1-arnaud.pouliquen@foss.st.com> <239eeeea-af04-7163-61ca-436c6632c2a8@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <239eeeea-af04-7163-61ca-436c6632c2a8@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 06:36:23PM +0100, Arnaud POULIQUEN wrote: > Hi Bjorn, > > On 1/24/22 11:25, Arnaud Pouliquen wrote: > > Updates from V8 [1]: > > - rebase on 5.17-rc1 + rpmsg char cdev release fixes[2][3] > > - updates based on Bjorn Andersson's comments: > > - remove rpmsg_create_default_ept API, set directly the ept->priv in rpmsg_chrdev_probe > > function. > > - rework commit message in [8/9]rpmsg: char: Introduce the "rpmsg-raw" channel > > > > Patchset description: > > > > The current rpmsg_char module implements a /dev/rpmsg_ctrl interface that provides the ability to > > instantiate char devices (/dev/rpmsgX) associated with an rpmsg endpoint for communication with the > > remote processor. > > This implementation fits with QCOM rpmsg backend but not with the magement by chanel implemented > > in the generic rpmsg virtio backend. > > This series restructures the rpmsg_char driver to decorrelate the control part from the data part > > in order to improve its compatible with the rpmsg virtio backend. > > > > Objective: > > - Expose a /dev/rpmsg_ctrlX interface for the application that is no longer dedicated to the > > rpmsg_char but generalized to all rpmsg services. This offers capability to create and destroy > > rpmsg channels from a user's application initiative (using the new RPMSG_CREATE_DEV_IOCTL and > > RPMSG_DESTROY_DEV_IOCTL controls). > > An application will be able to create/establish an rpmsg communication channel to communicate > > with the remote processor, and not only wait the remote processor initiative. > > This is interesting for example to establish a temporary communication link for diagnosis, > > calibration, debugging... or instantiate new data flows on some user actions. > > - Add capability to probe the rpmsg_char device at the initiative of the remote processor > > (rpmsg service announcement mechanism). > > This allows platforms based on the rpmsg virtio backend to create the /dev/rpmgX interface with > > a rpmsg name service announcement. > > > > Subsets: > > - Extract the control part of the char dev and create the rpmsg_ctrl.c file (patches 1 to 6) > > - Introduce the "rpmsg-raw" channel in rpmsg_char(patches 7 to 10) > > - Introduce the RPMSG_CREATE_DEV_IOCTL IOCTL and RPMSG_DESTROY_DEV_IOCTL to instantiate RPMsg > > devices (patch 11) > > The application can then create or release a channel by specifying: > > - the name service of the device to instantiate. > > - the source address. > > - the destination address. > > > > This series has be applied and tested on 'commit e783362eb54c ("Linux 5.17-rc1") + > > rpmsg_char cdev release fixes [2][3] > > > > [1] https://lkml.org/lkml/2021/12/7/186 > > [2] https://lkml.org/lkml/2022/1/10/1129 > > [3] https://lkml.org/lkml/2022/1/10/1130 > > > > Arnaud Pouliquen (11): > > rpmsg: char: Export eptdev create and destroy functions > > rpmsg: Create the rpmsg class in core instead of in rpmsg char > > rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl > > > > arm: configs: Configs that had RPMSG_CHAR now get RPMSG_CTRL > > RISC-V: configs: Configs that had RPMSG_CHAR now get RPMSG_CTRL > > arm64: defconfig: Config that had RPMSG_CHAR now gets RPMSG_CTRL > > Thank you for merging this series! > > I can't see in the "for next" branch[1] the 3 patches above that update configs > Are you expecting a specific action from me? Those patches will need to go through the Arm, RISC-V and arm64 subsystems. The mailing list for those subsystems has been CC'ed but that isn't enough to get the maintainers' attention. I suggest sending another patchset with those 3 patches that CC the maintainers directly. For the Arm patch I suggest adding Linus Walleij. Thanks, Mathieu > > [1]https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git > > Regards, > Arnaud > > > rpmsg: Update rpmsg_chrdev_register_device function > > rpmsg: char: Refactor rpmsg_chrdev_eptdev_create function > > rpmsg: char: Add possibility to use default endpoint of the rpmsg > > device > > rpmsg: char: Introduce the "rpmsg-raw" channel > > rpmsg: ctrl: Introduce new RPMSG_CREATE/RELEASE_DEV_IOCTL controls > > > > arch/arm/configs/qcom_defconfig | 1 + > > arch/arm64/configs/defconfig | 1 + > > arch/riscv/configs/defconfig | 1 + > > arch/riscv/configs/rv32_defconfig | 1 + > > drivers/rpmsg/Kconfig | 8 + > > drivers/rpmsg/Makefile | 1 + > > drivers/rpmsg/qcom_glink_native.c | 2 +- > > drivers/rpmsg/qcom_smd.c | 2 +- > > drivers/rpmsg/rpmsg_char.c | 231 +++++++++++----------------- > > drivers/rpmsg/rpmsg_char.h | 46 ++++++ > > drivers/rpmsg/rpmsg_core.c | 15 +- > > drivers/rpmsg/rpmsg_ctrl.c | 243 ++++++++++++++++++++++++++++++ > > drivers/rpmsg/rpmsg_internal.h | 10 +- > > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > > include/uapi/linux/rpmsg.h | 10 ++ > > 15 files changed, 419 insertions(+), 155 deletions(-) > > create mode 100644 drivers/rpmsg/rpmsg_char.h > > create mode 100644 drivers/rpmsg/rpmsg_ctrl.c > >