From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ABE0C433F5 for ; Fri, 25 Mar 2022 15:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355264AbiCYPSo (ORCPT ); Fri, 25 Mar 2022 11:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377402AbiCYPOR (ORCPT ); Fri, 25 Mar 2022 11:14:17 -0400 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F185583B0; Fri, 25 Mar 2022 08:12:17 -0700 (PDT) Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3892020001E; Fri, 25 Mar 2022 15:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1648221134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eAt+TBAfengvsI3opJRvj5GMA9ByOtG9TQG+M6MuH4E=; b=CaBSjKEDovabjcw3Z4WagEYRSCZbtxPBvJ/sFLGjWvvpemYnV934wMAsR13Evys2twwsAS pPrfqvdQeersxQhABxBUygfrm1/JlkQWjv2zLmgo4Y8g6gJ9dYBO9eJmwL2jSJGGmk1Vvw TqYdSqP5NGbAHF1mHiPNtrmorTLkVSc1fQeS4jVvynj/dht+CqR/gu3o7cdcDOK93UIQBl GjhB2/IOhUK9N4wG45hKI56wAy1GgaS55PpURQPr8rL+hw+53OpwrvRhhuHgZ8cLFDXgeD xMsBL2/UYK1hrVWoA/qfQoo38Y45zL3GtdnqTLGoZ177mTC0xI173zB30ahPcQ== Date: Fri, 25 Mar 2022 16:10:52 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Andy Shevchenko Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Wolfram Sang , Peter Rosin , Rob Herring , Frank Rowand , Len Brown , Hans de Goede , Thomas Petazzoni , Alexandre Belloni , Allan Nielsen , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 4/9] device property: add fwnode_property_read_string_index() Message-ID: <20220325161052.3ae6dd30@fixe.home> In-Reply-To: References: <20220325113148.588163-1-clement.leger@bootlin.com> <20220325113148.588163-5-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Fri, 25 Mar 2022 16:33:54 +0200, Andy Shevchenko a =C3=A9crit : > On Fri, Mar 25, 2022 at 12:31:43PM +0100, Cl=C3=A9ment L=C3=A9ger wrote: > > Add fwnode_property_read_string_index() function which allows to > > retrieve a single string from an array by its index. This function is > > the equivalent of of_property_read_string_index() but for fwnode > > support. =20 >=20 > ... >=20 > > + ret =3D fwnode_call_int_op(fwnode, property_read_string_array, propna= me, > > + string, 1, index); > > + if (ret =3D=3D -EINVAL && !IS_ERR_OR_NULL(fwnode) && > > + !IS_ERR_OR_NULL(fwnode->secondary)) > > + ret =3D fwnode_call_int_op(fwnode->secondary, > > + property_read_string_array, propname, > > + string, 1, index); =20 >=20 > This is not fully correct. See [1] for the details. > I hope to send the new version just after the merge window ends. >=20 > [1]: https://lore.kernel.org/lkml/20220308123712.18613-1-andriy.shevchenk= o@linux.intel.com/ >=20 Ok, I think we can wait for your patch to be applied in that case. --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com