public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable
@ 2022-03-26  8:43 Roger Quadros
  2022-03-26 14:09 ` Vignesh Raghavendra
  0 siblings, 1 reply; 3+ messages in thread
From: Roger Quadros @ 2022-03-26  8:43 UTC (permalink / raw)
  To: krzk
  Cc: miquel.raynal, tony, vigneshr, kishon, nm, linux-omap,
	linux-kernel, Roger Quadros

So far for armv7 TI platforms, GPMC was being selected by
arch/arm/mach-* architecture Kconfig files.

For K3 platforms, GPMC is no longer required for basic boot
and cannot be always enabled by default by mach- Kconfig.

We need a way for user (or board defconfig) to enable
it if required so ake OMAP_GPMC Kconfig option always visible.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/memory/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 30bff6cb1b8d..da2af9c38fe3 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -103,8 +103,8 @@ config TI_EMIF
 	  temperature changes
 
 config OMAP_GPMC
-	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
-	depends on OF_ADDRESS
+	bool "Texas Instruments OMAP SoC GPMC driver"
+	depends on OF_ADDRESS || COMPILE_TEST
 	select GPIOLIB
 	help
 	  This driver is for the General Purpose Memory Controller (GPMC)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable
  2022-03-26  8:43 [PATCH 1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros
@ 2022-03-26 14:09 ` Vignesh Raghavendra
  2022-03-26 14:36   ` Roger Quadros
  0 siblings, 1 reply; 3+ messages in thread
From: Vignesh Raghavendra @ 2022-03-26 14:09 UTC (permalink / raw)
  To: Roger Quadros, krzk
  Cc: miquel.raynal, tony, kishon, nm, linux-omap, linux-kernel

Hi Roger,

On 26/03/22 2:13 pm, Roger Quadros wrote:
> So far for armv7 TI platforms, GPMC was being selected by
> arch/arm/mach-* architecture Kconfig files.
> 
> For K3 platforms, GPMC is no longer required for basic boot
> and cannot be always enabled by default by mach- Kconfig.
> 
> We need a way for user (or board defconfig) to enable
> it if required so ake OMAP_GPMC Kconfig option always visible.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  drivers/memory/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 30bff6cb1b8d..da2af9c38fe3 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -103,8 +103,8 @@ config TI_EMIF
>  	  temperature changes
>  
>  config OMAP_GPMC
> -	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> -	depends on OF_ADDRESS
> +	bool "Texas Instruments OMAP SoC GPMC driver"
> +	depends on OF_ADDRESS || COMPILE_TEST

Can we make this tristate now, so that driver can be built as module?

>  	select GPIOLIB
>  	help
>  	  This driver is for the General Purpose Memory Controller (GPMC)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable
  2022-03-26 14:09 ` Vignesh Raghavendra
@ 2022-03-26 14:36   ` Roger Quadros
  0 siblings, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2022-03-26 14:36 UTC (permalink / raw)
  To: Vignesh Raghavendra, krzk
  Cc: miquel.raynal, tony, kishon, nm, linux-omap, linux-kernel

Hi Vignesh,

On 26/03/2022 16:09, Vignesh Raghavendra wrote:
> Hi Roger,
> 
> On 26/03/22 2:13 pm, Roger Quadros wrote:
>> So far for armv7 TI platforms, GPMC was being selected by
>> arch/arm/mach-* architecture Kconfig files.
>>
>> For K3 platforms, GPMC is no longer required for basic boot
>> and cannot be always enabled by default by mach- Kconfig.
>>
>> We need a way for user (or board defconfig) to enable
>> it if required so ake OMAP_GPMC Kconfig option always visible.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  drivers/memory/Kconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
>> index 30bff6cb1b8d..da2af9c38fe3 100644
>> --- a/drivers/memory/Kconfig
>> +++ b/drivers/memory/Kconfig
>> @@ -103,8 +103,8 @@ config TI_EMIF
>>  	  temperature changes
>>  
>>  config OMAP_GPMC
>> -	bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>> -	depends on OF_ADDRESS
>> +	bool "Texas Instruments OMAP SoC GPMC driver"
>> +	depends on OF_ADDRESS || COMPILE_TEST
> 
> Can we make this tristate now, so that driver can be built as module?

Sure, I'll give it a try.

> 
>>  	select GPIOLIB
>>  	help
>>  	  This driver is for the General Purpose Memory Controller (GPMC)

--
cheers,
-roger

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-26 14:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-26  8:43 [PATCH 1/1] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable Roger Quadros
2022-03-26 14:09 ` Vignesh Raghavendra
2022-03-26 14:36   ` Roger Quadros

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox