From: Masami Hiramatsu <mhiramat@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
kernel-janitors@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook
Date: Sat, 26 Mar 2022 10:20:47 +0900 [thread overview]
Message-ID: <20220326102047.61c095c112e0add6876446e2@kernel.org> (raw)
In-Reply-To: <Yj3zB2n7Hy0DhkU+@hirez.programming.kicks-ass.net>
On Fri, 25 Mar 2022 17:51:19 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Mar 25, 2022 at 03:43:15PM +0100, Peter Zijlstra wrote:
> > On Fri, Mar 25, 2022 at 11:22:53PM +0900, Masami Hiramatsu wrote:
> >
> > > Masami Hiramatsu (3):
> > > kprobes: Use rethook for kretprobe if possible
> > > rethook: kprobes: x86: Replace kretprobe with rethook on x86
> > > x86,kprobes: Fix optprobe trampoline to generate complete pt_regs
> > >
> > > Peter Zijlstra (1):
> > > Subject: x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs
> >
> > You fat-fingered the subject there ^
> >
> > Other than that:
> >
> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Hopefully the ftrace return trampoline can also be switched over..
>
> Urgh, allnoconfig doesn't build because..
>
> diff --git a/kernel/Makefile b/kernel/Makefile
> index 56f4ee97f328..471d71935e90 100644
> --- a/kernel/Makefile
> +++ b/kernel/Makefile
> @@ -108,6 +108,7 @@ obj-$(CONFIG_TRACING) += trace/
> obj-$(CONFIG_TRACE_CLOCK) += trace/
> obj-$(CONFIG_RING_BUFFER) += trace/
> obj-$(CONFIG_TRACEPOINTS) += trace/
> +obj-$(CONFIG_RETHOOK) += trace/
> obj-$(CONFIG_IRQ_WORK) += irq_work.o
> obj-$(CONFIG_CPU_PM) += cpu_pm.o
> obj-$(CONFIG_BPF) += bpf/
Oops, thanks for pointing out!
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-03-26 1:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 14:22 [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook Masami Hiramatsu
2022-03-25 14:23 ` [PATCH bpf-next v2 1/4] kprobes: Use rethook for kretprobe if possible Masami Hiramatsu
2022-03-25 14:23 ` [PATCH bpf-next v2 2/4] rethook: kprobes: x86: Replace kretprobe with rethook on x86 Masami Hiramatsu
2022-03-25 14:23 ` [PATCH bpf-next v2 3/4] Subject: x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs Masami Hiramatsu
2022-03-25 14:23 ` [PATCH bpf-next v2 4/4] x86,kprobes: Fix optprobe trampoline to generate " Masami Hiramatsu
2022-03-25 14:43 ` [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook Peter Zijlstra
2022-03-25 16:49 ` Alexei Starovoitov
2022-03-26 1:26 ` Masami Hiramatsu
2022-03-25 16:51 ` Peter Zijlstra
2022-03-26 1:20 ` Masami Hiramatsu [this message]
2022-03-26 1:09 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220326102047.61c095c112e0add6876446e2@kernel.org \
--to=mhiramat@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox