Re: [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks

Adam Ford
2022-03-31T16:00:45Z

On Thu, Mar 31, 2022 at 8:05 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Sun, 27 Mar 2022 at 14:39, Adam Ford <aford173@gmail.com> wrote:
> >
> > The SDHC controller in the imx8mn and imx8mp have the same controller
> > as the imx8mm which is slightly different than that of the imx7d.
> > Using the fallback of the imx8mm enables the controllers to support
> > HS400-ES which is not available on the imx7d. After discussion with NXP,
> > it turns out that the imx8qm should fall back to the imx8qxp, because
> > those have some additional flags not present in the imx8mm.
> >
> > Suggested-by: haibo.chen@nxp.com
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> I didn't quite follow all the discussions on patch3 - and whether that
> may affect the binding. Anyway, I assume you will send a new version.
> If not, please tell and will pick this up.

I am not sure exactly how the YAML should look, but I'm going to give
it a try. I hope to have something this weekend.

adam
>
> Kind regards
> Uffe
>
>
> > ---
> > V2: Added suggested-by note and imx8qxp updates.
> > ---
> > .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 16 +++++++++-------
> > 1 file changed, 9 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > index 7dbbcae9485c..1427e9b5a6ec 100644
> > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> > @@ -34,23 +34,25 @@ properties:
> > - fsl,imx6ull-usdhc
> > - fsl,imx7d-usdhc
> > - fsl,imx7ulp-usdhc
> > + - fsl,imx8mm-usdhc
> > + - fsl,imx8qxp-usdhc
> > - fsl,imxrt1050-usdhc
> > - nxp,s32g2-usdhc
> > - items:
> > - enum:
> > - - fsl,imx8mm-usdhc
> > - - fsl,imx8mn-usdhc
> > - - fsl,imx8mp-usdhc
> > - fsl,imx8mq-usdhc
> > - - fsl,imx8qm-usdhc
> > - - fsl,imx8qxp-usdhc
> > - const: fsl,imx7d-usdhc
> > - items:
> > - enum:
> > - - fsl,imx93-usdhc
> > + - fsl,imx8mn-usdhc
> > + - fsl,imx8mp-usdhc
> > - fsl,imx8ulp-usdhc
> > + - fsl,imx93-usdhc
> > - const: fsl,imx8mm-usdhc
> > -
> > + - items:
> > + - enum:
> > + - fsl,imx8qm-usdhc
> > + - const: fsl,imx8qxp-usdhc
> > reg:
> > maxItems: 1
> >
> > --
> > 2.34.1
> >