Re: [PATCH v1 3/3] sound: usb: Exynos usb audio offloading driver

[Oh Eomji <eomji.oh@samsung.com>]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

On Fri, Mar 25, 2022 at 07:44:31PM +0100, Krzysztof Kozlowski wrote:
> On 24/03/2022 09:10, Oh Eomji wrote:
> > This is for usb audio offloading. usb audio offloading processes usb
> > audio stream data directly from the audio box even if ap usb enters
> > suspend, there is no problem in stream data transmission. This obtains
> > power saving effect while using usb audio device.
> > 
> > AP usb and audio usb f/w communicate via AUDIO IPC. By performing AUDIO
> > IPC in the vendor operations, abox can access and control the xhci to
> > transmit the data directly.
> > 
> > The types of commands and data delivered through AUDIO IPC include the
> > following (AP USB <-> AUDIO USB f/w) :
> > 1. usb audio connection/disconnection status
> > 2. xhci memory information
> > 3. full descriptor for usb audio device
> > 4. UAC(usb audio class) control command
> > 
> > Signed-off-by: Oh Eomji <eomji.oh@samsung.com>
> > ---
> >  sound/usb/Kconfig            |   9 +
> >  sound/usb/Makefile           |   2 +
> >  sound/usb/exynos_usb_audio.c | 560 +++++++++++++++++++++++++++++++++++++++++++
> >  sound/usb/exynos_usb_audio.h | 150 ++++++++++++
> >  4 files changed, 721 insertions(+)
> >  create mode 100644 sound/usb/exynos_usb_audio.c
> >  create mode 100644 sound/usb/exynos_usb_audio.h
> 
> Similar pattern as XHCI submission - it looks like you do not work on
> mainline kernel, but some other, private tree with other modifications.
> It seems you created this series based on that private tree.
> 
> This is not the proper process.
> 
> Please rebase all your work on recent mainline kernel (v5.18-rc1,
> linux-next) and work there.
> 
> Then you can start using get_maintainers.pl...
> 
> BTW, this v2, not v1, so please version it correctly. Add also changelog
> to your series in cover letter.
> 
> Best regards,
> Krzysztof
>
Okay, I will rebase and modify the patch version in the next patch.

Thanks,
Eomji Oh

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]