From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C28FC43219 for ; Mon, 28 Mar 2022 11:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241426AbiC1Lab (ORCPT ); Mon, 28 Mar 2022 07:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241743AbiC1LYK (ORCPT ); Mon, 28 Mar 2022 07:24:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 864F05621C; Mon, 28 Mar 2022 04:22:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2CC4EB81057; Mon, 28 Mar 2022 11:22:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8923C34100; Mon, 28 Mar 2022 11:22:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648466527; bh=V7H00UtlLngdCRjCXEwVG9SICi2PzqEv68IR/NchaQU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rAIiF0s6H+OODy9ufVtMOu2jN46U3Rj8awbaVh4W3EePSOUR9yTdseJbseqWWbKu1 XWvwvuimdLPQLAsiLvfQLckz5dlLpxmYo3itEVZvF9T3SDBcPGhNFyKYMDg80G2+vX R3xWShjwJG4gI6pDr2P4ugWOGuebExpq4sxfJuZbzm9C1hvrgjGPv0s1p27TnbueZP hknzAWVY4wG88CATcrXWyRcZln54SLNjFrOQjBDBPL1lwlG1KCWGjpUMpIXhv6lMQv IfWasMTkHpXtb8xSpa5nuN6lCoSFoi7QLoc9tPOCqDc+qSuAmc1i2i6f92FXWrIC0W XYvwOWk3ytCAA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: "Souptick Joarder (HPE)" , kernel test robot , Dan Carpenter , Marc Zyngier , Sasha Levin , tglx@linutronix.de Subject: [PATCH AUTOSEL 5.15 17/29] irqchip/nvic: Release nvic_base upon failure Date: Mon, 28 Mar 2022 07:21:19 -0400 Message-Id: <20220328112132.1555683-17-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220328112132.1555683-1-sashal@kernel.org> References: <20220328112132.1555683-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Souptick Joarder (HPE)" [ Upstream commit e414c25e3399b2b3d7337dc47abccab5c71b7c8f ] smatch warning was reported as below -> smatch warnings: drivers/irqchip/irq-nvic.c:131 nvic_of_init() warn: 'nvic_base' not released on lines: 97. Release nvic_base upon failure. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Souptick Joarder (HPE) Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220218163303.33344-1-jrdr.linux@gmail.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-nvic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/irqchip/irq-nvic.c b/drivers/irqchip/irq-nvic.c index 599bb6fc5f0a..47b3b165479e 100644 --- a/drivers/irqchip/irq-nvic.c +++ b/drivers/irqchip/irq-nvic.c @@ -92,6 +92,7 @@ static int __init nvic_of_init(struct device_node *node, if (!nvic_irq_domain) { pr_warn("Failed to allocate irq domain\n"); + iounmap(nvic_base); return -ENOMEM; } @@ -101,6 +102,7 @@ static int __init nvic_of_init(struct device_node *node, if (ret) { pr_warn("Failed to allocate irq chips\n"); irq_domain_remove(nvic_irq_domain); + iounmap(nvic_base); return ret; } -- 2.34.1