From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2BADC433EF for ; Mon, 28 Mar 2022 13:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241399AbiC1NKo (ORCPT ); Mon, 28 Mar 2022 09:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242544AbiC1NKd (ORCPT ); Mon, 28 Mar 2022 09:10:33 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 214FC5EDD2 for ; Mon, 28 Mar 2022 06:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648472905; x=1680008905; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4QdSkMKEUwTVu1jBDwmTQc7nMMREGDePFvtO9WBjuxc=; b=lGHcQ1shuuRYSnWc8cEkIhnC1MOlsNhv1/hSinS7C6g1FjHcRPirG1ez IZ2z6q/4NKSB4B9ql3T0WCCDi+gjukOxlX3/90NVjpZ4gvvh1RdkHT4mp XMm6UvcPdWhimfcRSb4s3RQrd82Pw+m/zLEDIWPmdkjJGJ4xsaV0CRdfM 6XTiFaGx8NVNYMZWCG+CeYCCOAm/YsFQuc5+uyOmJ1QCQZxdAov1iL2g+ igjL2BZqTJzKMAviT8fw4RL3ujafRc7euWI+Le09/3Dmmw60s+swJBqE3 mAvMUZBDqvydGTfv+ZDeec5aYy3TsAoZP0iqDM+T41tOKonS4DBMk5t11 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10299"; a="239587139" X-IronPort-AV: E=Sophos;i="5.90,217,1643702400"; d="scan'208";a="239587139" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 06:08:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,217,1643702400"; d="scan'208";a="502504017" Received: from lkp-server02.sh.intel.com (HELO 89b41b6ae01c) ([10.239.97.151]) by orsmga003.jf.intel.com with ESMTP; 28 Mar 2022 06:08:19 -0700 Received: from kbuild by 89b41b6ae01c with local (Exim 4.92) (envelope-from ) id 1nYp6P-00023a-Qd; Mon, 28 Mar 2022 13:08:09 +0000 Date: Mon, 28 Mar 2022 21:07:15 +0800 From: kernel test robot To: Mohan Kumar , tiwai@suse.com, kai.vehmanen@linux.intel.com, perex@perex.cz, ville.syrjala@linux.intel.com Cc: kbuild-all@lists.01.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, Mohan Kumar Subject: Re: [PATCH] ALSA: hda: Avoid unsol event during RPM suspending Message-ID: <202203282137.YsDmfIAj-lkp@intel.com> References: <20220328091411.31488-1-mkumard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220328091411.31488-1-mkumard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mohan, Thank you for the patch! Yet something to improve: [auto build test ERROR on tiwai-sound/for-next] [also build test ERROR on v5.17 next-20220328] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Mohan-Kumar/ALSA-hda-Avoid-unsol-event-during-RPM-suspending/20220328-171517 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: alpha-buildonly-randconfig-r001-20220327 (https://download.01.org/0day-ci/archive/20220328/202203282137.YsDmfIAj-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/80c4e21f5e97cd4b779806fa5da5bb7392e2874f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Mohan-Kumar/ALSA-hda-Avoid-unsol-event-during-RPM-suspending/20220328-171517 git checkout 80c4e21f5e97cd4b779806fa5da5bb7392e2874f # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash sound/pci/hda/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): sound/pci/hda/patch_hdmi.c: In function 'hdmi_present_sense_via_verbs': >> sound/pci/hda/patch_hdmi.c:1644:28: error: 'struct dev_pm_info' has no member named 'runtime_status' 1644 | (dev->power.runtime_status == RPM_SUSPENDING)) | ^ vim +1644 sound/pci/hda/patch_hdmi.c 1620 1621 /* update ELD and jack state via HD-audio verbs */ 1622 static void hdmi_present_sense_via_verbs(struct hdmi_spec_per_pin *per_pin, 1623 int repoll) 1624 { 1625 struct hda_codec *codec = per_pin->codec; 1626 struct hdmi_spec *spec = codec->spec; 1627 struct hdmi_eld *eld = &spec->temp_eld; 1628 struct device *dev = hda_codec_dev(codec); 1629 hda_nid_t pin_nid = per_pin->pin_nid; 1630 int dev_id = per_pin->dev_id; 1631 /* 1632 * Always execute a GetPinSense verb here, even when called from 1633 * hdmi_intrinsic_event; for some NVIDIA HW, the unsolicited 1634 * response's PD bit is not the real PD value, but indicates that 1635 * the real PD value changed. An older version of the HD-audio 1636 * specification worked this way. Hence, we just ignore the data in 1637 * the unsolicited response to avoid custom WARs. 1638 */ 1639 int present; 1640 int ret; 1641 1642 ret = snd_hda_power_up_pm(codec); 1643 if ((ret < 0 && pm_runtime_suspended(dev)) || > 1644 (dev->power.runtime_status == RPM_SUSPENDING)) 1645 goto out; 1646 1647 present = snd_hda_jack_pin_sense(codec, pin_nid, dev_id); 1648 1649 mutex_lock(&per_pin->lock); 1650 eld->monitor_present = !!(present & AC_PINSENSE_PRESENCE); 1651 if (eld->monitor_present) 1652 eld->eld_valid = !!(present & AC_PINSENSE_ELDV); 1653 else 1654 eld->eld_valid = false; 1655 1656 codec_dbg(codec, 1657 "HDMI status: Codec=%d NID=0x%x Presence_Detect=%d ELD_Valid=%d\n", 1658 codec->addr, pin_nid, eld->monitor_present, eld->eld_valid); 1659 1660 if (eld->eld_valid) { 1661 if (spec->ops.pin_get_eld(codec, pin_nid, dev_id, 1662 eld->eld_buffer, &eld->eld_size) < 0) 1663 eld->eld_valid = false; 1664 } 1665 1666 update_eld(codec, per_pin, eld, repoll); 1667 mutex_unlock(&per_pin->lock); 1668 out: 1669 snd_hda_power_down_pm(codec); 1670 } 1671 -- 0-DAY CI Kernel Test Service https://01.org/lkp