Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail

Dan Carpenter
2022-03-29T09:09:21Z

On Tue, Mar 29, 2022 at 10:28:24AM +0200, Fabio M. De Francesco wrote:
> Therefore, I suppose that you are suggesting the following simple change:
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index a390679cf458..13d96d0f9dde 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -3474,6 +3474,7 @@ static int sd_probe(struct device *dev)
>
> error = device_add_disk(dev, gd, NULL);
> if (error) {
> + device_del(&sdkp->disk_dev);
> put_device(&sdkp->disk_dev);
> goto out;
> }
>
> Did I get it?

Yep.