Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail

Dan Carpenter
2022-03-29T07:48:15Z

No, this patch is wrong. That is supposed to be freed in scsi_disk_release()
but apparently that's not getting called. Is the ref counting off?

On Tue, Mar 29, 2022 at 08:18:16AM +0200, Fabio M. De Francesco wrote:
> > There is a larger process issue here. We need to figure out why syzbot
> > did not detect that this patch introduces bugs.
>
> This is something that the people who run Syzbot/Syzkaller should help to
> figure out.

Yeah. Right now syzbot just says "TEST PASSED" but it doesn't give a
complete dmesg. There were other leaks on this path. Were they not
detected? We can't know without looking at the dmesg.