RE: [PATCH] soc/tegra: pmc: update Tegra234 reset sources

Sandipan Patra
2022-04-01T10:12:20Z

Thanks Andy for reviewing the patch.

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Wednesday, March 30, 2022 2:46 PM
> To: Sandipan Patra <spatra@nvidia.com>
> Cc: Thierry Reding <treding@nvidia.com>; Jonathan Hunter
> <jonathanh@nvidia.com>; digetx@gmail.com; ulf.hansson@linaro.org;
> cai.huoqing@linux.dev; Bibek Basu <bbasu@nvidia.com>; linux-
> tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] soc/tegra: pmc: update Tegra234 reset sources
>
> External email: Use caution opening links or attachments
>
>
> On Wed, Mar 30, 2022 at 12:06:35PM +0530, Sandipan Patra wrote:
> > Reset_sources list is updated to add all reset sources and removing
> > ones that do not actually exist.
>
> ...
>
> > + "SYS_RESET_N", /*0*/
>
> Missed spaces in the comment here and everywhere else.
ACK
>
> Not sure about indices. If it's going to be a part of the hardware
> programming interface it may make sense to use hexadecimal rather than
> decimal.
Agree. That's a better suggestion for readability too, I will modify it to have hexadecimal in next patch.

Thanks & Regards,
Sandipan
>
> --
> With Best Regards,
> Andy Shevchenko
>