From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, kim.phillips@amd.com,
acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com,
rafael@kernel.org, ravi.bangoria@amd.com, Sandipan.Das@amd.com
Subject: Re: [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support
Date: Wed, 30 Mar 2022 13:01:51 +0200 [thread overview]
Message-ID: <20220330110151.GJ8939@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <CABPqkBQ6ZyqSzQyJeNW5GE22V1sygB3zz5JQ45AT1TxMnwWScg@mail.gmail.com>
On Tue, Mar 29, 2022 at 04:47:52PM -0700, Stephane Eranian wrote:
> False alarm. I had not forced the config option. With the config
> option enabled, it works as expected.
Great!
> I just found a minor issue in case BRS is not enabled. To be
> consistent, we should do:
>
> --- a/arch/x86/events/perf_event.h
> +++ b/arch/x86/events/perf_event.h
> @@ -1265,7 +1265,7 @@ static inline s64 amd_brs_adjust_period(s64 period)
> #else
> static inline int amd_brs_init(void)
> {
> - return 0;
> + return -EOPNOTSUPP;
> }
Done!
prev parent reply other threads:[~2022-03-30 11:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 22:15 [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/core: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] x86/cpufeatures: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/x86/amd: Enable " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/x86/amd: Make " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 08/13] ACPI: add perf low power callback Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] ACPI: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-04-05 8:36 ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 10/13] perf tools: fix NULL point in evsel__env() Stephane Eranian
2022-03-23 19:01 ` Kim Phillips
2022-03-25 18:27 ` Arnaldo Carvalho de Melo
2022-03-25 20:02 ` Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-03-25 21:46 ` Arnaldo Carvalho de Melo
2022-03-25 21:53 ` Arnaldo Carvalho de Melo
2022-03-22 22:15 ` [PATCH v7 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
2022-03-24 14:59 ` [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Peter Zijlstra
2022-03-25 5:31 ` Stephane Eranian
2022-03-25 8:28 ` Peter Zijlstra
2022-03-29 21:58 ` Stephane Eranian
2022-03-29 23:47 ` Stephane Eranian
2022-03-30 11:01 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330110151.GJ8939@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Sandipan.Das@amd.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox