From: Jason Gunthorpe <jgg@nvidia.com>
To: Shlomo Pongratz <shlomopongratz@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew.maier@eideticom.com, logang@deltatee.com,
bhelgaas@google.com, helgaas@kernel.org,
Shlomo Pongratz <shlomop@pliops.com>
Subject: Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check.
Date: Wed, 30 Mar 2022 12:37:20 -0300 [thread overview]
Message-ID: <20220330153720.GF1716663@nvidia.com> (raw)
In-Reply-To: <20220330140823.28826-2-shlomop@pliops.com>
On Wed, Mar 30, 2022 at 05:08:23PM +0300, Shlomo Pongratz wrote:
> @@ -350,7 +353,10 @@ static struct pci_dev *pci_host_bridge_dev(struct pci_host_bridge *host)
>
> if (!root)
> return NULL;
> - if (root->devfn != PCI_DEVFN(0, 0))
> +
> + /* Is it a host bridge or a root port? */
This is a better comment:
/* host bridges must have a 0 devfn, but some of the entries in the
whilelist are root ports that can have any devfn */
> + if (root->devfn != PCI_DEVFN(0, 0) &&
> + pci_pcie_type(root) != PCI_EXP_TYPE_ROOT_PORT)
> return NULL;
Indentation is wrong
Jason
next prev parent reply other threads:[~2022-03-30 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 14:08 [PATCH V4 0/1] Intel Sky Lake-E host root ports check Shlomo Pongratz
2022-03-30 14:08 ` [PATCH V4 1/1] " Shlomo Pongratz
2022-03-30 15:20 ` Logan Gunthorpe
2022-03-30 15:37 ` Jason Gunthorpe [this message]
2022-03-30 19:10 ` Bjorn Helgaas
2022-03-30 19:11 ` Jason Gunthorpe
2022-03-30 19:36 ` Logan Gunthorpe
2022-03-30 19:38 ` Jason Gunthorpe
2022-03-30 19:46 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330153720.GF1716663@nvidia.com \
--to=jgg@nvidia.com \
--cc=andrew.maier@eideticom.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=shlomop@pliops.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox