From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28627C433FE for ; Thu, 31 Mar 2022 01:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352305AbiCaBYv (ORCPT ); Wed, 30 Mar 2022 21:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbiCaBYq (ORCPT ); Wed, 30 Mar 2022 21:24:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6DB12E9C4; Wed, 30 Mar 2022 18:22:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15F216191D; Thu, 31 Mar 2022 01:22:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F382C340F0; Thu, 31 Mar 2022 01:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648689778; bh=NWJILtetxPEKc8/hlIa004NMQJu2a/09BnjLlYqqPg8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TyE9YM8MKt+M9uNRj+xDC1911Vd7uLDQyOJTzDhJxYSeWbYABBlwTTn6Se5xFhxxf XaOU6ancOjgWR7UeOYLsbm95v+lrz1Z6LvpF44is7BXZGQdQYsoRDfKDeB1bNepQiS z8mt2pz7CVUZ1KJQqUjFxihCtq5ckqzE+f9mu9UF2xdIwOLVvx9owww3cMPjeXfDPH pzGgGhi0aP5d4aUVAZTDQkC9WkrO96fJm0NROoLjYK5iq1l2glisJxf4O7AVIfryUJ MQRCjbXgVzGvvk99R3VlsnxcueZqIwh1075rCrvbm965BcXqMP/W6BiouOInJs66eV 7w5S/hkUI16Ow== Date: Thu, 31 Mar 2022 10:22:53 +0900 From: Masami Hiramatsu To: Mathieu Desnoyers Cc: Steven Rostedt , linux-kernel@vger.kernel.org, Beau Belgrave , Masami Hiramatsu , linux-trace-devel , bpf , Network Development , Alexei Starovoitov , Linus Torvalds Subject: Re: [PATCH] tracing: do not export user_events uapi Message-Id: <20220331102253.8793580dbc02c93dd897e52a@kernel.org> In-Reply-To: <20220330201755.29319-1-mathieu.desnoyers@efficios.com> References: <20220330201755.29319-1-mathieu.desnoyers@efficios.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Mar 2022 16:17:55 -0400 Mathieu Desnoyers wrote: > In addition to mark the USER_EVENTS feature BROKEN until all interested > parties figure out the user-space API, do not install the uapi header. > > This prevents situations where a non-final uapi header would end up > being installed into a distribution image and used to build user-space > programs that would then run against newer kernels that will implement > user events with a different ABI. > > Link: https://lore.kernel.org/all/20220330155835.5e1f6669@gandalf.local.home > Looks good to me. Reviewed-by: Masami Hiramatsu Thank you, > Signed-off-by: Mathieu Desnoyers > --- > include/uapi/Kbuild | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild > index 61ee6e59c930..425ea8769ddc 100644 > --- a/include/uapi/Kbuild > +++ b/include/uapi/Kbuild > @@ -12,3 +12,6 @@ ifeq ($(wildcard $(objtree)/arch/$(SRCARCH)/include/generated/uapi/asm/kvm_para. > no-export-headers += linux/kvm_para.h > endif > endif > + > +# API is not finalized > +no-export-headers += linux/user_events.h > -- > 2.20.1 > -- Masami Hiramatsu