Re: [PATCH] tracing: do not export user_events uapi

Masami Hiramatsu
2022-03-31T01:23:07Z

On Wed, 30 Mar 2022 16:17:55 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> In addition to mark the USER_EVENTS feature BROKEN until all interested
> parties figure out the user-space API, do not install the uapi header.
>
> This prevents situations where a non-final uapi header would end up
> being installed into a distribution image and used to build user-space
> programs that would then run against newer kernels that will implement
> user events with a different ABI.
>
> Link: https://lore.kernel.org/all/20220330155835.5e1f6669@gandalf.local.home
>

Looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you,

> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---
> include/uapi/Kbuild | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild
> index 61ee6e59c930..425ea8769ddc 100644
> --- a/include/uapi/Kbuild
> +++ b/include/uapi/Kbuild
> @@ -12,3 +12,6 @@ ifeq ($(wildcard $(objtree)/arch/$(SRCARCH)/include/generated/uapi/asm/kvm_para.
> no-export-headers += linux/kvm_para.h
> endif
> endif
> +
> +# API is not finalized
> +no-export-headers += linux/user_events.h
> --
> 2.20.1
>

--
Masami Hiramatsu <mhiramat@kernel.org>