From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DC0C4332F for ; Fri, 1 Apr 2022 11:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345592AbiDALrE (ORCPT ); Fri, 1 Apr 2022 07:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345577AbiDALrB (ORCPT ); Fri, 1 Apr 2022 07:47:01 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C4F89EEA72; Fri, 1 Apr 2022 04:45:11 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1naFiG-0000xJ-00; Fri, 01 Apr 2022 13:45:08 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id B9B39C4DEF; Fri, 1 Apr 2022 12:03:09 +0200 (CEST) Date: Fri, 1 Apr 2022 12:03:09 +0200 From: Thomas Bogendoerfer To: Paul Cercueil Cc: Nick Desaulniers , Nathan Chancellor , Herbert Xu , "David S . Miller" , "Maciej W . Rozycki" , linux-crypto@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org, kernel test robot Subject: Re: [PATCH] MIPS: crypto: Fix CRC32 code Message-ID: <20220401100309.GA6670@alpha.franken.de> References: <20220331164200.177015-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331164200.177015-1-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2022 at 05:42:00PM +0100, Paul Cercueil wrote: > Commit 67512a8cf5a7 ("MIPS: Avoid macro redefinitions") changed how the > MIPS register macros were defined, in order to allow the code to compile > under LLVM/Clang. > > The MIPS CRC32 code however wasn't updated accordingly, causing a build > bug when using a MIPS32r6 toolchain without CRC support. > > Update the CRC32 code to use the macros correctly, to fix the build > failures. > > Fixes: 67512a8cf5a7 ("MIPS: Avoid macro redefinitions") > Cc: > Signed-off-by: Paul Cercueil > Reported-by: kernel test robot > --- > arch/mips/crypto/crc32-mips.c | 46 ++++++++++++++++++++--------------- > 1 file changed, 26 insertions(+), 20 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]