From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<Divya.Koppera@microchip.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <UNGLinuxDriver@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: [PATCH net v2 3/3] net: phy: micrel: Remove DT option lan8814,ignore-ts
Date: Fri, 1 Apr 2022 13:05:22 +0200 [thread overview]
Message-ID: <20220401110522.3418258-4-horatiu.vultur@microchip.com> (raw)
In-Reply-To: <20220401110522.3418258-1-horatiu.vultur@microchip.com>
When the PHY and the MAC are capable of doing timestamping, the PHY has
priority. Therefore the DT option lan8814,ignore-ts was added such that
the PHY will not expose a PHC so then the timestamping was done in the
MAC. This is not the correct approach of doing it, therefore remove
this.
Fixes: ece19502834d84 ("net: phy: micrel: 1588 support for LAN8814 phy")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/phy/micrel.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index a873df07ad24..fc53b71dc872 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -2616,7 +2616,6 @@ static int lan8814_config_init(struct phy_device *phydev)
static int lan8814_probe(struct phy_device *phydev)
{
- const struct device_node *np = phydev->mdio.dev.of_node;
struct kszphy_priv *priv;
u16 addr;
int err;
@@ -2630,8 +2629,7 @@ static int lan8814_probe(struct phy_device *phydev)
phydev->priv = priv;
if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
- !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING) ||
- of_property_read_bool(np, "lan8814,ignore-ts"))
+ !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
return 0;
/* Strap-in value for PHY address, below register read gives starting
--
2.33.0
next prev parent reply other threads:[~2022-04-01 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 11:05 [PATCH net v2 0/3] net: phy: micrel: Remove latencies support lan8814 Horatiu Vultur
2022-04-01 11:05 ` [PATCH net v2 1/3] dt-bindings: net: micrel: Revert latency support and timestamping check Horatiu Vultur
2022-04-01 11:05 ` [PATCH net v2 2/3] net: phy: micrel: Remove latency from driver Horatiu Vultur
2022-04-01 11:05 ` Horatiu Vultur [this message]
2022-04-01 12:57 ` [PATCH net v2 0/3] net: phy: micrel: Remove latencies support lan8814 Andrew Lunn
2022-04-01 14:11 ` Allan W. Nielsen
2022-04-01 14:39 ` Andrew Lunn
2022-04-02 13:43 ` Richard Cochran
2022-04-01 14:43 ` Russell King (Oracle)
2022-04-04 12:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401110522.3418258-4-horatiu.vultur@microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox