public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "Wander Lairson Costa" <wander@redhat.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Johan Hovold" <johan@kernel.org>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Lukas Wunner" <lukas@wunner.de>, "Pali Rohár" <pali@kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>,
	senozhatsky@chromium.org, andre.goddard@gmail.com,
	sudipm.mukherjee@gmail.com, andy.shevchenko@gmail.com,
	David.Laight@aculab.com, jonathanh@nvidia.com,
	phil@raspberrypi.com
Subject: Re: [PATCH v5 1/1] serial/8250: Use fifo in 8250 console driver
Date: Fri, 1 Apr 2022 12:07:05 -0400	[thread overview]
Message-ID: <20220401120705.533896e5@gandalf.local.home> (raw)
In-Reply-To: <4767809d-5818-ad40-a0e7-b3af40aa071e@kernel.org>

On Fri, 1 Apr 2022 06:35:58 +0200
Jiri Slaby <jirislaby@kernel.org> wrote:

> > With the help of the function tracer, I then noticed the serial
> > controller was taking around 410us seconds to dispatch one single byte:
> > 
> > $ trace-cmd record -p function_graph -g serial8250_console_write \
> >     ./sertest -n 1 /tmp/serco
> > 
> > $ trace-cmd report
> > 

Note, the function graph tracer can add a noticeable amount of overhead to
these timings. If you want a more accurate time for a function, just trace
that one function:

	trace-cmd record -p function_graph -l serial8250_console_write ...

As that will only trace the serial8250_console_write() function (think of
-l as "limit"), and the overhead of function graph for tracing a single
function becomes negligible, and then you can see the true time of that
function.

-- Steve

  parent reply	other threads:[~2022-04-01 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 19:02 [PATCH v5 0/1] serial/8250: Use fifo in 8250 console driver Wander Lairson Costa
2022-03-31 19:02 ` [PATCH v5 1/1] " Wander Lairson Costa
2022-04-01  4:35   ` Jiri Slaby
2022-04-01 14:26     ` Wander Costa
2022-04-01 16:07     ` Steven Rostedt [this message]
2022-04-01 20:20       ` Wander Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401120705.533896e5@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=David.Laight@aculab.com \
    --cc=andre.goddard@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=macro@orcam.me.uk \
    --cc=pali@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=senozhatsky@chromium.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox