Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label

Martin Kaiser
2022-04-02T11:45:55Z

Thus wrote Fabio M. De Francesco (fmdefrancesco@gmail.com):

> > > pnpi = netdev_priv(netdev);

> > > if (!pnpi->priv)
> > > - goto RETURN;
> > > + return;

> I cannot see how pnpi->priv might ever be NULL.

Even if pnpi->priv was NULL, we wouldn't need the check. It's ok to call
vfree(NULL).

> After the two removals I've talked about above, the code will always call
> vfree(pnpi->priv) and then free_netdev(netdev).

That makes sense.

Best regards,
Martin