Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label

Fabio M. De Francesco
2022-04-02T13:23:01Z

On sabato 2 aprile 2022 13:45:33 CEST Martin Kaiser wrote:
> Thus wrote Fabio M. De Francesco (fmdefrancesco@gmail.com):
>
> > > > pnpi = netdev_priv(netdev);
>
> > > > if (!pnpi->priv)
> > > > - goto RETURN;
> > > > + return;
>
> > I cannot see how pnpi->priv might ever be NULL.
>
> Even if pnpi->priv was NULL, we wouldn't need the check. It's ok to call
> vfree(NULL).
>
> > After the two removals I've talked about above, the code will always call
> > vfree(pnpi->priv) and then free_netdev(netdev).
>
> That makes sense.
>
> Best regards,
> Martin
>
Hi Martin,

Thanks for reminding to me that a vfree() on a NULL pointer is a no-op.
I'm going to submit a new patch with the purpose to re-work rtw_free_netdev().

Thanks again,

Fabio