linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Florian Westphal <fw@strlen.de>,
	Vasily Averin <vasily.averin@linux.dev>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	kernel@openvz.org, Jozsef Kadlecsik <kadlec@netfilter.org>,
	netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH nft] nft: memcg accounting for dynamically allocated objects
Date: Sat, 2 Apr 2022 01:01:58 +0200	[thread overview]
Message-ID: <20220401230158.GC28321@breakpoint.cc> (raw)
In-Reply-To: <YkdrRAiO1P7segcd@carbon.dhcp.thefacebook.com>

Roman Gushchin <roman.gushchin@linux.dev> wrote:
> On Fri, Apr 01, 2022 at 09:31:59PM +0200, Florian Westphal wrote:
> > But what task/memcg is used for the accounting in that case?
> 
> Root memcg/no accounting, which is the same.
> 
> There is a way to account for a specific memcg in such cases, it's used for
> bpf maps, for example. We save a pointer to the memcg which created the map and
> charge it for all allocations from a !in_task context.

Great, so we could use same scheme later on if its required for some
use case.

>  so let's not do without regression tests and a serious need.

Sounds good. Thanks.

  reply	other threads:[~2022-04-01 23:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220228122429.GC26547@breakpoint.cc>
2022-03-21  5:02 ` [PATCH v2] memcg: enable accounting for nft objects Vasily Averin
2022-03-22 10:25   ` Florian Westphal
2022-03-24 14:19   ` Pablo Neira Ayuso
2022-03-24 17:23     ` Vasily Averin
2022-03-24 18:05 ` [PATCH v2 RESEND] " Vasily Averin
2022-03-28  8:15   ` Pablo Neira Ayuso
2022-03-28  9:23     ` Vasily Averin
2022-03-31  8:40       ` [PATCH nft] nft: memcg accounting for dynamically allocated objects Vasily Averin
2022-03-31 18:45         ` Roman Gushchin
2022-04-01 12:03         ` Florian Westphal
2022-04-01 18:56           ` Vasily Averin
2022-04-01 19:31             ` Florian Westphal
2022-04-01 21:14               ` Roman Gushchin
2022-04-01 23:01                 ` Florian Westphal [this message]
2022-04-02  8:55               ` Vasily Averin
2022-04-02  9:50                 ` [PATCH v2] " Vasily Averin
2022-04-05  9:58                   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401230158.GC28321@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=kernel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=roman.gushchin@linux.dev \
    --cc=vasily.averin@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).