* [PATCH] regulator: atc260x: Fix missing active_discharge_on setting
@ 2022-04-03 13:22 Axel Lin
2022-04-05 9:32 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2022-04-03 13:22 UTC (permalink / raw)
To: Mark Brown
Cc: Manivannan Sadhasivam, Cristian Ciocaltea,
Liam Girdwood linux-actions @ lists . infradead . org,
linux-kernel, Axel Lin
Without active_discharge_on setting, the SWITCH1 discharge enable control
is always disabled. Fix it.
Fixes: 3b15ccac161a ("regulator: Add regulator driver for ATC260x PMICs")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/atc260x-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/atc260x-regulator.c b/drivers/regulator/atc260x-regulator.c
index 05147d2c3842..485e58b264c0 100644
--- a/drivers/regulator/atc260x-regulator.c
+++ b/drivers/regulator/atc260x-regulator.c
@@ -292,6 +292,7 @@ enum atc2603c_reg_ids {
.bypass_mask = BIT(5), \
.active_discharge_reg = ATC2603C_PMU_SWITCH_CTL, \
.active_discharge_mask = BIT(1), \
+ .active_discharge_on = BIT(1), \
.owner = THIS_MODULE, \
}
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: atc260x: Fix missing active_discharge_on setting
2022-04-03 13:22 [PATCH] regulator: atc260x: Fix missing active_discharge_on setting Axel Lin
@ 2022-04-05 9:32 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-04-05 9:32 UTC (permalink / raw)
To: axel.lin; +Cc: mani, cristian.ciocaltea, linux-kernel, lgirdwood
On Sun, 3 Apr 2022 21:22:35 +0800, Axel Lin wrote:
> Without active_discharge_on setting, the SWITCH1 discharge enable control
> is always disabled. Fix it.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: atc260x: Fix missing active_discharge_on setting
commit: 2316f0fc0ad2aa87a568ceaf3d76be983ee555c3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-05 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-03 13:22 [PATCH] regulator: atc260x: Fix missing active_discharge_on setting Axel Lin
2022-04-05 9:32 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox