Re: [PATCH 1/5] staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIV

Michael Straube
2022-04-05T13:23:21Z

Hi Greg,

On 4/4/22 16:32, Greg KH wrote:
>> +bool support_ant_div(struct adapter *adapter)
>
> That's a very odd function name to add to the kernel's global namespace
> :(
>
> Pleas emake it more obvious what this is for, with the driver name as
> part of the prefix?
>

Looking again at this I notice it can be made a static function in
rtw_cmd.c.

I'll rework the series and make the function static with a more
descriptive name.

thanks,
Michael