Re: [PATCH 2/2] staging: rtl8712: Fix Lines shouldn't end with '('

Greg KH
2022-04-03T08:57:43Z

On Sat, Apr 02, 2022 at 02:28:17PM +0200, Alaa Mohamed wrote:
> Fix " CHECK: Lines should not end with a '(' "
> Reported by checkpatch
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_xmit.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c
> index 05ba0ca7d627..d43c097f30c3 100644
> --- a/drivers/staging/rtl8712/rtl8712_xmit.c
> +++ b/drivers/staging/rtl8712/rtl8712_xmit.c
> @@ -638,16 +638,12 @@ int r8712_xmitframe_complete(struct _adapter *padapter,
> if (p2ndxmitframe) {
> u16 total_length;
>
> - total_length = r8712_xmitframe_aggr_next(
> - pxmitbuf, p2ndxmitframe);
> + total_length = r8712_xmitframe_aggr_next(pxmitbuf, p2ndxmitframe);
> do {
> - p2ndxmitframe = dequeue_xframe_ex(
> - pxmitpriv, phwxmits, hwentry);
> + p2ndxmitframe = dequeue_xframe_ex(pxmitpriv, phwxmits, hwentry);
> if (p2ndxmitframe)
> total_length =
> - r8712_xmitframe_aggr_next(
> - pxmitbuf,
> - p2ndxmitframe);
> + r8712_xmitframe_aggr_next(pxmitbuf, p2ndxmitframe);

And now you went over 80 columns :(

You can do this better so that you still wrap lines, but do not trail
with a '(' character.

thanks,

greg k-h