From: Jan Varho <jan.varho@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-kernel@vger.kernel.org, Jan Varho <jan.varho@gmail.com>
Subject: [PATCH] random: fix add_hwgenerator_randomness entropy accounting
Date: Mon, 4 Apr 2022 18:04:42 +0300 [thread overview]
Message-ID: <20220404150442.934496-1-jan.varho@gmail.com> (raw)
add_hwgenerator_randomness tries to only use the required amound of input
for fast init, but credits all the entropy if even a byte was left over.
Fix by not crediting entropy if any input was consumed for fast init.
Signed-off-by: Jan Varho <jan.varho@gmail.com>
---
drivers/char/random.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 1d8242969751..fb20178f1044 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1141,12 +1141,10 @@ void add_hwgenerator_randomness(const void *buffer, size_t count,
size_t entropy)
{
if (unlikely(crng_init == 0 && entropy < POOL_MIN_BITS)) {
- size_t ret = crng_pre_init_inject(buffer, count, true);
- mix_pool_bytes(buffer, ret);
- count -= ret;
- buffer += ret;
- if (!count || crng_init == 0)
+ if (crng_pre_init_inject(buffer, count, true) > 0) {
+ mix_pool_bytes(buffer, count);
return;
+ }
}
/*
--
2.25.1
next reply other threads:[~2022-04-04 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 15:04 Jan Varho [this message]
2022-04-04 15:20 ` [PATCH] random: fix add_hwgenerator_randomness entropy accounting Jason A. Donenfeld
2022-04-04 15:29 ` Jan Varho
2022-04-04 16:10 ` Jason A. Donenfeld
2022-04-04 16:20 ` [PATCH v2] " Jan Varho
2022-04-04 16:42 ` [PATCH v3] " Jan Varho
2022-04-04 17:37 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404150442.934496-1-jan.varho@gmail.com \
--to=jan.varho@gmail.com \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox