From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31AB5C3527D for ; Tue, 5 Apr 2022 23:42:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1579154AbiDEX0T (ORCPT ); Tue, 5 Apr 2022 19:26:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386637AbiDEMzA (ORCPT ); Tue, 5 Apr 2022 08:55:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 24D2035269 for ; Tue, 5 Apr 2022 04:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649159947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=caJ3Mn8x8sphClTxTGmFig0egR97QkRAGfFS5UfDfJg=; b=iMJFKuyd/NBBDuasFz+Q19WyHs8C7u61QUqviYeugCG9DDi3fB/04ubzBzwagCheInmqgz KC7volVEs2MjcggioH5JIo+jxd/6fC6eyjduVUE5JlPSJsHMmZNa55Icckq9Wsau+oMOzu eNwUgue0KuQf8euHSXsu3d+va/5refk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-C5yzQZkLNIu-BwW0aaP_fg-1; Tue, 05 Apr 2022 07:59:06 -0400 X-MC-Unique: C5yzQZkLNIu-BwW0aaP_fg-1 Received: by mail-wr1-f72.google.com with SMTP id j18-20020adfa552000000b002060a011303so1553466wrb.14 for ; Tue, 05 Apr 2022 04:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=caJ3Mn8x8sphClTxTGmFig0egR97QkRAGfFS5UfDfJg=; b=PjBJCyRdByM26EfNLiTMQugjSpdTBAQBYBaPMwQ9urJ3b2OydWF14FMV6n6naGQSia 5FOE9VFwhUKksKeB8oACI7cpgzEevl5FZyiQHzsyBKnueVOnVwkHcC//tqnxHTftR6YQ CbeH2LE6PGqUJ1Zm82mhIi3EXROwegWYOk6txkj/rlP3gjgXwZbCj9hJE50ORofeNp2+ G5Rd/HmxLDQPhmWF2AJLHCcbQ/MKWQnO48aRgg4iB7Gbh8s5KBN03ojNhe+rss8o8L42 /lC1RXx9stmNS6RNPY67Ao34KaDcageypnAIrgAghpBbW0gGgtaYvm9VAH/0PA/IoPiO 6KeQ== X-Gm-Message-State: AOAM533uZjaNKgQ81gu7I10VqaTSMqckTc8NAe6o03Hw4PE4KvmkA+vG SmX2VnO8wA6Lz1ir++QTrpvsrk1T4oYCoiYEt5ga00ATaZoJMWTodXy7kXSW/JwZuxtIpbYgjdc WcpxhVIxCPx0VyzGGls/H4p1p X-Received: by 2002:a1c:f705:0:b0:37d:f2e5:d8ec with SMTP id v5-20020a1cf705000000b0037df2e5d8ecmr2850173wmh.21.1649159944331; Tue, 05 Apr 2022 04:59:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgAb5I4ZF3qI+9Z9tb/LO2zK3svds/SwszckCB8AT7KGF6vHKrXQi2sIZ1Gsir9F/APs8Zzw== X-Received: by 2002:a1c:f705:0:b0:37d:f2e5:d8ec with SMTP id v5-20020a1cf705000000b0037df2e5d8ecmr2850160wmh.21.1649159944150; Tue, 05 Apr 2022 04:59:04 -0700 (PDT) Received: from redhat.com ([2.52.17.211]) by smtp.gmail.com with ESMTPSA id w7-20020a1cf607000000b00389a5390180sm1949693wmc.25.2022.04.05.04.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 04:59:03 -0700 (PDT) Date: Tue, 5 Apr 2022 07:59:00 -0400 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: Masahiro Yamada , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 8/8] virtio_ring.h: do not include from exported header Message-ID: <20220405075756-mutt-send-email-mst@kernel.org> References: <20220404061948.2111820-1-masahiroy@kernel.org> <20220404061948.2111820-9-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 04, 2022 at 12:44:30AM -0700, Christoph Hellwig wrote: > On Mon, Apr 04, 2022 at 03:19:48PM +0900, Masahiro Yamada wrote: > > vr->num = num; > > vr->desc = p; > > vr->avail = (struct vring_avail *)((char *)p + num * sizeof(struct vring_desc)); > > - vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16) > > + vr->used = (void *)(((__kernel_uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16) > > + align-1) & ~(align - 1)); > > This really does not look like it should be in a uapi header to start > with. It's a way to document a complex structure layout of virtio 0.9. It's ugly but it's been like this for years. For virtio 1.0 we moved away from this but a bunch of tools keep using legacy. -- MST