From: Frederic Weisbecker <frederic@kernel.org>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] timers: Initialize base::next_expiry_recalc during prepare cpu
Date: Tue, 5 Apr 2022 23:51:28 +0200 [thread overview]
Message-ID: <20220405215128.GA1359823@lothringen> (raw)
In-Reply-To: <20220405191732.7438-2-anna-maria@linutronix.de>
On Tue, Apr 05, 2022 at 09:17:31PM +0200, Anna-Maria Behnsen wrote:
> When base::next_expiry_recalc is not initialized to false during cpu
> bringup in HOTPLUG_CPU and is accidently true and no timer is queued in the
> meantime, the loop through the wheel to find __next_timer_interrupt() might
> be done for nothing.
>
> Therefore initialize base::next_expiry_recalc to false in
> timers_prepare_cpu().
>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
next prev parent reply other threads:[~2022-04-06 2:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 19:17 [PATCH 0/2] timers: Small fixes Anna-Maria Behnsen
2022-04-05 19:17 ` [PATCH 1/2] timers: Initialize base::next_expiry_recalc during prepare cpu Anna-Maria Behnsen
2022-04-05 21:51 ` Frederic Weisbecker [this message]
2022-04-09 20:22 ` [tip: timers/core] timers: Initialize base::next_expiry_recalc in timers_prepare_cpu() tip-bot2 for Anna-Maria Behnsen
2022-04-05 19:17 ` [PATCH 2/2] timers: Fix warning in __run_timers() Anna-Maria Behnsen
2022-04-05 21:43 ` Frederic Weisbecker
2022-04-09 20:22 ` [tip: timers/core] timers: Fix warning condition " tip-bot2 for Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405215128.GA1359823@lothringen \
--to=frederic@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox