From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823C3C433EF for ; Wed, 6 Apr 2022 14:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234937AbiDFOzZ (ORCPT ); Wed, 6 Apr 2022 10:55:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235203AbiDFOzM (ORCPT ); Wed, 6 Apr 2022 10:55:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 088E133A8E9; Tue, 5 Apr 2022 19:05:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57FF861544; Wed, 6 Apr 2022 02:05:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B886DC385A1; Wed, 6 Apr 2022 02:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649210750; bh=acChcUw+dtLQiG63ZL5fQxXE+Lczp9WNFEL8waQsqPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mJVe9uh4OfYhQBkko31BKfMYBXQgMj+Y6d+POb7aTAmnB3eY1pk13Dvotb8xYtXDT 4QRNeA/t4fnp1cpgQHG2Tedm0SX+9JH8NdED3eo9jiZ5fHCJBoSaBZd99tmzf5k/B2 boccLvW/W5Xj/hxSsKNQFQOPXsGxFJKegEG854wfLLM0yn2o8gQkautNeKRZBG/kCH vR3LD4230NJuqs+feM0whJ99MmHNwDV65lnIOjadk0pTov2L5+vaK/B45HZ01u6W0e Y/xPGDSctg+4A3Hr9rXIun0hznibuwejIAB9PFrqqRdoyBL/BhyeGgX3oa/HtiXQkm Tu4At8Ig1vfUw== Date: Wed, 6 Apr 2022 10:05:42 +0800 From: Shawn Guo To: Oleksij Rempel Cc: Mark Rutland , Rob Herring , Sascha Hauer , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Robin van der Gracht , devicetree@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , David Jander , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 5/8] ARM: dts: imx6qdl-vicut1/vicutgo: The sgtl5000 uses i2s not ac97 Message-ID: <20220406020542.GF129381@dragon> References: <20220221095312.3692669-1-o.rempel@pengutronix.de> <20220221095312.3692669-5-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221095312.3692669-5-o.rempel@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 21, 2022 at 10:53:09AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > According to Documentation/devicetree/bindings/sound/fsl,ssi.txt > 'fsl,mode' should be specified for AC97 mode only. > > The 'fsl,ssi' documentation doesn't say anything about specifying > 'sound-dai-cells' so we'll remove that as well. Hmm, what needs to be fixed is fsl,ssi binding doc, I think. Shawn > > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-victgo.dts | 2 -- > arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts > index d542ddad4e32..20c7f80e5ec9 100644 > --- a/arch/arm/boot/dts/imx6dl-victgo.dts > +++ b/arch/arm/boot/dts/imx6dl-victgo.dts > @@ -591,8 +591,6 @@ &pwm3 { > }; > > &ssi1 { > - #sound-dai-cells = <0>; > - fsl,mode = "ac97-slave"; > status = "okay"; > }; > > diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi > index ec39008c0950..97ef8264947a 100644 > --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi > @@ -466,8 +466,6 @@ &pwm3 { > }; > > &ssi1 { > - #sound-dai-cells = <0>; > - fsl,mode = "ac97-slave"; > status = "okay"; > }; > > -- > 2.30.2 >