From: Ivan Bornyakov <i.bornyakov@metrotek.ru>
To: Andrew Lunn <andrew@lunn.ch>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, system@metrotek.ru
Subject: Re: [PATCH net] net: phy: marvell-88x2222: set proper phydev->port
Date: Wed, 6 Apr 2022 12:09:08 +0300 [thread overview]
Message-ID: <20220406090908.mkpvndnsby5f3473@h-e2.ddg> (raw)
In-Reply-To: <Ykxq0wx7eMiZCXgx@lunn.ch>
On Tue, Apr 05, 2022 at 06:14:11PM +0200, Andrew Lunn wrote:
> On Tue, Apr 05, 2022 at 06:03:05PM +0300, Ivan Bornyakov wrote:
> > phydev->port was not set and always reported as PORT_TP.
> > Set phydev->port according to inserted SFP module.
>
> This is definitely something for Russell to review.
>
> But i'm wondering if this is the correct place to do this? What about
> at803x and marvell10g?
I guess them need this too, but I only have HW with Marvell 88X2222.
> It seems like this should be done once in the
> core somewhere, not in each driver.
>
> Andrew
Apart from sfp_parse_port(), sfp_parse_support() and
sfp_select_interface() are also present in all
sfp_upstream_ops->module_insert PHY callbacks.
next prev parent reply other threads:[~2022-04-06 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 15:03 [PATCH net] net: phy: marvell-88x2222: set proper phydev->port Ivan Bornyakov
2022-04-05 16:14 ` Andrew Lunn
2022-04-06 9:09 ` Ivan Bornyakov [this message]
2022-04-25 4:16 ` [PATCH net-next RESEND] " Ivan Bornyakov
2022-04-25 21:33 ` Russell King (Oracle)
2022-04-26 7:46 ` Ivan Bornyakov
2022-06-12 18:19 ` [PATCH v2 net-next] " Ivan Bornyakov
2022-06-15 8:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220406090908.mkpvndnsby5f3473@h-e2.ddg \
--to=i.bornyakov@metrotek.ru \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=system@metrotek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox