From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC845C433FE for ; Thu, 7 Apr 2022 01:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233880AbiDGBMl (ORCPT ); Wed, 6 Apr 2022 21:12:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233533AbiDGBMf (ORCPT ); Wed, 6 Apr 2022 21:12:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3484186D8; Wed, 6 Apr 2022 18:10:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7233F61DAF; Thu, 7 Apr 2022 01:10:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 304F3C385A3; Thu, 7 Apr 2022 01:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649293836; bh=potqC08jkvZW9/U+vgAilEzYyFF0q7v+dSF+fh3Bx2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ilkl3266YuPHN0BdgUdc4n5pOK4wxGofnFrLdKbg8ZFgU5hyvSvzZD7yFQUOxWbiZ TyUstSMKJXV6I+EnH9aeCKZci3YGkO7LWkxLGCaCmSPoUrsji45hTIHsfIzmWltsSR 5zh1X+IDg0NGUmYzOl6gBggy5+a+6XDqvRs28yOJfu3FEa8en0JU23gzRGWPD0Sa7P 7Gkga8KmJ5XLpLH7Vhab4tC7b/WHamomicglua5wWDcRxfCBtVq8JL/BkXgW62DNpY kTpv40C6DY/81l5wqv45XDD2qpwN6xR5SFDuMOlFtZgyv6jv1iJyObj56GPUzzT3wH 11iSMJl+gMbzg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hugo Villeneuve , Alexandre Belloni , Sasha Levin , a.zummo@towertech.it, linux-rtc@vger.kernel.org Subject: [PATCH AUTOSEL 5.17 05/31] rtc: pcf2127: fix bug when reading alarm registers Date: Wed, 6 Apr 2022 21:10:03 -0400 Message-Id: <20220407011029.113321-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220407011029.113321-1-sashal@kernel.org> References: <20220407011029.113321-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hugo Villeneuve [ Upstream commit 73ce05302007eece23a6acb7dc124c92a2209087 ] The first bug is that reading the 5 alarm registers results in a read operation of 20 bytes. The reason is because the destination buffer is defined as an array of "unsigned int", and we use the sizeof() operator on this array to define the bulk read count. The second bug is that the read value is invalid, because we are indexing the destination buffer as integers (4 bytes), instead of indexing it as u8. Changing the destination buffer type to u8 fixes both problems. Signed-off-by: Hugo Villeneuve Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220208162908.3182581-1-hugo@hugovil.com Signed-off-by: Sasha Levin --- drivers/rtc/rtc-pcf2127.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 81a5b1f2e68c..6c9d8de41e7b 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -374,7 +374,8 @@ static int pcf2127_watchdog_init(struct device *dev, struct pcf2127 *pcf2127) static int pcf2127_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) { struct pcf2127 *pcf2127 = dev_get_drvdata(dev); - unsigned int buf[5], ctrl2; + u8 buf[5]; + unsigned int ctrl2; int ret; ret = regmap_read(pcf2127->regmap, PCF2127_REG_CTRL2, &ctrl2); -- 2.35.1