From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B78C4332F for ; Thu, 7 Apr 2022 01:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240873AbiDGBa1 (ORCPT ); Wed, 6 Apr 2022 21:30:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240522AbiDGBUD (ORCPT ); Wed, 6 Apr 2022 21:20:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 086EDE9978; Wed, 6 Apr 2022 18:17:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B6CDFB81E7F; Thu, 7 Apr 2022 01:17:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2682C385A6; Thu, 7 Apr 2022 01:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649294272; bh=vSlTdS4frT8Mjmykvy79Ms7L46FQR7yZhRuJyxtB7tU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RMAhFhCOB/2hMrxoZeQ9ayY9I4b7HfrojgdfxKziTvKVN8r24YWPrFMABWPC57cvi 8juaaQRvVHflBSCv7W6bIGyk1dgPvunnGp0ifxJ+wxx2KvB5QihHRHpP8/Of97gGqh V8TDo+TMpMcQ/gYsg2YsaY3TYo7MIk1s0WbPcAix5DpNkrT7Tz75VC0pZHyXWSx8JZ Gl5CemoVNaL6QQvKaWqOj2ZwxhIF41PVTBkwymgtqUUUDclfPa48cRcFDAOYsQ+3Y/ xvpRi7s7YmPFZvOiJ4qLLcgZcuki/TseeDbp1D0DMfOwhj0wT0Bjm7NyZt/uHyodlT 1qCPg7OCF6xHQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeff LaBundy , =?UTF-8?q?Tomasz=20Mo=C5=84?= , Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 4/7] Input: add bounds checking to input_set_capability() Date: Wed, 6 Apr 2022 21:17:37 -0400 Message-Id: <20220407011740.115717-4-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220407011740.115717-1-sashal@kernel.org> References: <20220407011740.115717-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff LaBundy [ Upstream commit 409353cbe9fe48f6bc196114c442b1cff05a39bc ] Update input_set_capability() to prevent kernel panic in case the event code exceeds the bitmap for the given event type. Suggested-by: Tomasz Moń Signed-off-by: Jeff LaBundy Reviewed-by: Tomasz Moń Link: https://lore.kernel.org/r/20220320032537.545250-1-jeff@labundy.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/input.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/input/input.c b/drivers/input/input.c index cb31236425a1..f65306f74339 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -50,6 +50,17 @@ static DEFINE_MUTEX(input_mutex); static const struct input_value input_value_sync = { EV_SYN, SYN_REPORT, 1 }; +static const unsigned int input_max_code[EV_CNT] = { + [EV_KEY] = KEY_MAX, + [EV_REL] = REL_MAX, + [EV_ABS] = ABS_MAX, + [EV_MSC] = MSC_MAX, + [EV_SW] = SW_MAX, + [EV_LED] = LED_MAX, + [EV_SND] = SND_MAX, + [EV_FF] = FF_MAX, +}; + static inline int is_event_supported(unsigned int code, unsigned long *bm, unsigned int max) { @@ -1913,6 +1924,14 @@ EXPORT_SYMBOL(input_free_device); */ void input_set_capability(struct input_dev *dev, unsigned int type, unsigned int code) { + if (type < EV_CNT && input_max_code[type] && + code > input_max_code[type]) { + pr_err("%s: invalid code %u for type %u\n", __func__, code, + type); + dump_stack(); + return; + } + switch (type) { case EV_KEY: __set_bit(code, dev->keybit); -- 2.35.1