From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.garry@huawei.com>
Cc: damien.lemoal@opensource.wdc.com, hch@lst.de,
linux-doc@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] libata: Improve ATA queued command allocation
Date: Thu, 7 Apr 2022 15:32:32 +0200 [thread overview]
Message-ID: <20220407133232.GA7092@lst.de> (raw)
In-Reply-To: <1649333365-100672-1-git-send-email-john.garry@huawei.com>
> + qc = __ata_qc_from_tag(ap, tag);
> + qc->tag = qc->hw_tag = tag;
> + qc->scsicmd = NULL;
> + qc->ap = ap;
> + qc->dev = dev;
> +
> + ata_qc_reinit(qc);
> +
> + qc->scsicmd = cmd;
My fault, byt we can remove the first qc->scsicmd a nothing looks
at the field before this real initialization.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2022-04-07 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 12:09 [PATCH v3] libata: Improve ATA queued command allocation John Garry
2022-04-07 13:32 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407133232.GA7092@lst.de \
--to=hch@lst.de \
--cc=damien.lemoal@opensource.wdc.com \
--cc=john.garry@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox