linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Haowen Bai <baihaowen@meizu.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ethernet: Fix some formatting issues
Date: Thu, 7 Apr 2022 19:38:28 -0700	[thread overview]
Message-ID: <20220407193828.6c95928c@kernel.org> (raw)
In-Reply-To: <1649327764-29869-1-git-send-email-baihaowen@meizu.com>

On Thu, 7 Apr 2022 18:36:04 +0800 Haowen Bai wrote:
> reported by checkpatch.pl

Please don't send "checkpatch fixes" for networking.

> WARNING: suspect code indent for conditional statements (16, 16)
> #732: FILE: drivers/net/ethernet/3com/3c589_cs.c:732:
> CHECK: Alignment should match open parenthesis
> #733: FILE: drivers/net/ethernet/3com/3c589_cs.c:733:
> CHECK: Alignment should match open parenthesis
> #735: FILE: drivers/net/ethernet/3com/3c589_cs.c:735:
> WARNING: suspect code indent for conditional statements (16, 16)
> #736: FILE: drivers/net/ethernet/3com/3c589_cs.c:736:
> CHECK: Alignment should match open parenthesis
> #737: FILE: drivers/net/ethernet/3com/3c589_cs.c:737:
> CHECK: Alignment should match open parenthesis
> #739: FILE: drivers/net/ethernet/3com/3c589_cs.c:739:
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>

      reply	other threads:[~2022-04-08  2:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 10:36 [PATCH V2] ethernet: Fix some formatting issues Haowen Bai
2022-04-08  2:38 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407193828.6c95928c@kernel.org \
    --to=kuba@kernel.org \
    --cc=baihaowen@meizu.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).