From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port
Date: Thu, 7 Apr 2022 20:47:28 +0200 [thread overview]
Message-ID: <20220407204728.7710ebfa@coco.lan> (raw)
In-Reply-To: <0dac70ef-1355-3379-ef41-eec6467886b1@linux.intel.com>
Em Wed, 6 Apr 2022 22:08:53 -0500
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> escreveu:
> > static int sof_es8316_speaker_power_event(struct snd_soc_dapm_widget *w,
> > @@ -145,13 +148,23 @@ static const struct snd_soc_dapm_route sof_es8316_audio_map[] = {
> > {"Speaker", NULL, "HPOL"},
> > {"Speaker", NULL, "HPOR"},
> > {"Speaker", NULL, "Speaker Power"},
> > +
> > + {"Differential Mux", "lin1-rin1", "MIC1"},
> > + {"Differential Mux", "lin2-rin2", "MIC2"},
> > + {"Differential Mux", "lin1-rin1 with 20db Boost", "MIC1"},
> > + {"Differential Mux", "lin2-rin2 with 20db Boost", "MIC2"},
>
> this is surprising, shouldn't this be part of the codec driver?
>
> The part that should be machine-specific is really how MIC1 or MIC2 are
> connected (as done below), but the routes above seem machine-independent?
Yeah, this should be there... and it is there already ;-)
Tested without it and it still works.
So, I'll just drop the above.
Thanks,
Mauro
next prev parent reply other threads:[~2022-04-07 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 20:19 [PATCH v4 0/4] Make headphone work on Huawei Matebook D15 Mauro Carvalho Chehab
2022-04-06 20:19 ` [PATCH v4 1/4] ASoC: Intel: sof_es8336: simplify speaker gpio naming Mauro Carvalho Chehab
2022-04-06 20:19 ` [PATCH v4 2/4] ASoC: Intel: sof_es8336: support a separate gpio to control headphone Mauro Carvalho Chehab
2022-04-06 20:19 ` [PATCH v4 3/4] ASoC: Intel: sof_es8336: add a quirk for headset at mic1 port Mauro Carvalho Chehab
2022-04-07 3:08 ` Pierre-Louis Bossart
2022-04-07 18:47 ` Mauro Carvalho Chehab [this message]
2022-04-06 20:19 ` [PATCH v4 4/4] ASoC: Intel: sof_es8336: Add a quirk for Huawei Matebook D15 Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407204728.7710ebfa@coco.lan \
--to=mchehab@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox