From: Ian Rogers <irogers@google.com>
To: "John Garry" <john.garry@huawei.com>,
"Will Deacon" <will@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Leo Yan" <leo.yan@linaro.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"James Clark" <james.clark@arm.com>,
"Alexandre Truong" <alexandre.truong@arm.com>,
"German Gomez" <german.gomez@arm.com>,
"Ian Rogers" <irogers@google.com>,
"Dave Marchevsky" <davemarchevsky@fb.com>,
"Song Liu" <songliubraving@fb.com>,
"Ravi Bangoria" <ravi.bangoria@amd.com>,
"Li Huafei" <lihuafei1@huawei.com>,
"Martin Liška" <mliska@suse.cz>,
"William Cohen" <wcohen@redhat.com>,
"Riccardo Mancini" <rickyman7@gmail.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Thomas Richter" <tmricht@linux.ibm.com>,
"Lexi Shao" <shaolexi@huawei.com>,
"Remi Bernon" <rbernon@codeweavers.com>,
"Michael Petlan" <mpetlan@redhat.com>,
"Denis Nikitin" <denik@chromium.org>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>
Subject: [PATCH 0/5] Tidy up symbol end fixup
Date: Thu, 7 Apr 2022 16:04:58 -0700 [thread overview]
Message-ID: <20220407230503.1265036-1-irogers@google.com> (raw)
Fixing up more symbol ends as introduced in:
https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/
caused perf annotate to run into memory limits - every symbol holds
all the disassembled code in the annotation, and so making symbols
ends further away dramatically increased memory usage (40MB to
>1GB). Modify the symbol end logic so that special kernel cases aren't
applied in the common case.
Minor fix to perf annotate to not stall when stderr is full.
Ian Rogers (5):
perf annotate: Drop objdump stderr
perf symbols: Always do architecture specific fixups
perf symbols: Add is_kernel argument to fixup end
perf symbol: By default only fix zero length symbols
perf symbols: More specific architecture end fixing
tools/perf/arch/arm64/util/machine.c | 14 +++++++++-----
tools/perf/arch/powerpc/util/machine.c | 10 +++++++---
tools/perf/arch/s390/util/machine.c | 12 ++++++++----
tools/perf/util/annotate.c | 1 +
tools/perf/util/symbol-elf.c | 2 +-
tools/perf/util/symbol.c | 14 ++++++++------
tools/perf/util/symbol.h | 4 ++--
7 files changed, 36 insertions(+), 21 deletions(-)
--
2.35.1.1178.g4f1659d476-goog
next reply other threads:[~2022-04-07 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 23:04 Ian Rogers [this message]
2022-04-07 23:04 ` [PATCH 1/5] perf annotate: Drop objdump stderr Ian Rogers
2022-04-09 15:44 ` Arnaldo Carvalho de Melo
2022-04-07 23:05 ` [PATCH 2/5] perf symbols: Always do architecture specific fixups Ian Rogers
2022-04-07 23:05 ` [PATCH 3/5] perf symbols: Add is_kernel argument to fixup end Ian Rogers
2022-04-12 7:58 ` [perf symbols] 309f68878e: perf-sanity-tests.perf.make_fail kernel test robot
2022-04-07 23:05 ` [PATCH 4/5] perf symbol: By default only fix zero length symbols Ian Rogers
2022-04-07 23:05 ` [PATCH 5/5] perf symbols: More specific architecture end fixing Ian Rogers
2022-04-08 17:15 ` [PATCH 0/5] Tidy up symbol end fixup Namhyung Kim
2022-04-08 23:52 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407230503.1265036-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.truong@arm.com \
--cc=davemarchevsky@fb.com \
--cc=denik@chromium.org \
--cc=eranian@google.com \
--cc=german.gomez@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mliska@suse.cz \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rbernon@codeweavers.com \
--cc=rickyman7@gmail.com \
--cc=shaolexi@huawei.com \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=wcohen@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox