From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yihao Han <hanyihao@vivo.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fabio Aiuto <fabioaiuto83@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Xiangyang Zhang <xyz.sun.ok@gmail.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Bryan Brattlof <hello@bryanbrattlof.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@vivo.com
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary `if`
Date: Fri, 8 Apr 2022 17:12:35 +0300 [thread overview]
Message-ID: <20220408141235.GU3293@kadam> (raw)
In-Reply-To: <20220408135921.16534-1-hanyihao@vivo.com>
On Fri, Apr 08, 2022 at 06:59:11AM -0700, Yihao Han wrote:
> remove a unnecesarry if in `sd_recv_rxfifo`
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
^^^
Under this cut off line then you need to say what changed since version
1. Something like: "v2: more extensive cleanup. v3: edit commit message".
I do want you to edit the commit message because I don't think it really
describes the patch very well. How I would write this commit message is
this:
[PATCH v3] staging: rtl8723bs: tidy up error handling
The check for if rtw_skb_alloc() fails is done twice and is written
in a confusing way. Move the "if (!recvbuf->pskb)" right after
the allocation. The "if (recvbuf->pskb)" check can now be deleted
and the code pulled in one tab.
To me this explains the problem and the solution.
regards,
dan carpenter
prev parent reply other threads:[~2022-04-08 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 7:42 [PATCH] staging: rtl8723bs: simplify if-if to if-else Yihao Han
2022-04-08 8:51 ` Dan Carpenter
2022-04-08 13:59 ` [PATCH v2] staging: rtl8723bs: remove unnecessary `if` Yihao Han
2022-04-08 14:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408141235.GU3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanyihao@vivo.com \
--cc=hello@bryanbrattlof.com \
--cc=kernel@vivo.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xyz.sun.ok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox