From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yihao Han <hanyihao@vivo.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fabio Aiuto <fabioaiuto83@gmail.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Xiangyang Zhang <xyz.sun.ok@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Bryan Brattlof <hello@bryanbrattlof.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@vivo.com
Subject: Re: [PATCH v3] staging: rtl8723bs: tidy up error handling
Date: Fri, 8 Apr 2022 17:58:36 +0300 [thread overview]
Message-ID: <20220408145836.GV3293@kadam> (raw)
In-Reply-To: <20220408144442.17611-1-hanyihao@vivo.com>
On Fri, Apr 08, 2022 at 07:44:40AM -0700, Yihao Han wrote:
> The check for if rtw_skb_alloc() fails is done twice and is written
> in a confusing way. Move the "if (!recvbuf->pskb)" right after
> the allocation. The "if (recvbuf->pskb)" check can now be deleted
> and the code pulled in one tab.
>
> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> v2: more extensive cleanup
> v3: edit commit message
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2022-04-08 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:44 [PATCH v3] staging: rtl8723bs: tidy up error handling Yihao Han
2022-04-08 14:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408145836.GV3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanyihao@vivo.com \
--cc=hello@bryanbrattlof.com \
--cc=kernel@vivo.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xyz.sun.ok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox