From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
jstultz@google.com, Stephen Boyd <sboyd@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [RFC][PATCH] timers: Add del_time_free() to be called before freeing timers
Date: Fri, 8 Apr 2022 20:22:30 -0400 [thread overview]
Message-ID: <20220408202230.0ea5388f@rorschach.local.home> (raw)
In-Reply-To: <87v8vjiaih.ffs@tglx>
On Fri, 08 Apr 2022 22:29:58 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:
> Well, you'd have to reinitialize it first before the explicit rearm
> because the shutdown cleared the function pointer or if we use a flag
> then the flag would prevent arming it again.
We could always use the LSB bit of the function as a "shutdown" flag, where:
timer_shutdown() {
[..]
timer->fn = (void *)((unsigned long)timer->fn | 1);
[..]
}
timer_rearm() {
[..]
timer->fn = (void *)((unsigned long)timer->fn & ~1UL);
[..]
}
mod_timer() {
if ((unsigned long)timer->fn & 1)
return -EBUSY?;
[..]
}
-- Steve
next prev parent reply other threads:[~2022-04-09 0:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 20:17 [RFC][PATCH] timers: Add del_time_free() to be called before freeing timers Steven Rostedt
2022-04-07 21:58 ` Guenter Roeck
2022-04-07 22:51 ` Steven Rostedt
2022-04-08 0:58 ` Guenter Roeck
2022-04-08 1:36 ` Steven Rostedt
2022-04-08 10:37 ` Thomas Gleixner
2022-04-08 12:33 ` Steven Rostedt
2022-04-08 15:55 ` Steven Rostedt
2022-04-08 17:33 ` Linus Torvalds
2022-04-08 20:10 ` Steven Rostedt
2022-04-08 20:26 ` Steven Rostedt
2022-04-08 23:18 ` Linus Torvalds
2022-04-08 20:29 ` Thomas Gleixner
2022-04-08 20:58 ` Steven Rostedt
2022-04-08 21:46 ` Thomas Gleixner
2022-04-08 21:59 ` Steven Rostedt
2022-04-09 0:22 ` Steven Rostedt [this message]
2022-04-09 0:30 ` Linus Torvalds
2022-04-09 0:49 ` Steven Rostedt
2022-04-09 1:00 ` Linus Torvalds
2022-04-09 1:14 ` Steven Rostedt
2022-11-24 14:16 ` [tip: timers/core] timers: Provide timer_shutdown[_sync]() tip-bot2 for Thomas Gleixner
2022-11-24 14:16 ` [tip: timers/core] timers: Add shutdown mechanism to the internal functions tip-bot2 for Thomas Gleixner
2022-11-24 14:16 ` [tip: timers/core] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode tip-bot2 for Thomas Gleixner
2022-11-24 14:16 ` [tip: timers/core] timers: Silently ignore timers with a NULL function tip-bot2 for Thomas Gleixner
2022-11-24 14:16 ` [tip: timers/core] timers: Use del_timer_sync() even on UP tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408202230.0ea5388f@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=peterz@infradead.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox