From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] x86: PUSH_AND_CLEAR_REGS_COMPAT
Date: Fri, 8 Apr 2022 19:00:28 -0700 [thread overview]
Message-ID: <20220409020028.wfcwidlvg5rgwpki@treble> (raw)
In-Reply-To: <20220408231447.GS2731@worktop.programming.kicks-ass.net>
On Sat, Apr 09, 2022 at 01:14:47AM +0200, Peter Zijlstra wrote:
> On Sat, Apr 09, 2022 at 12:38:27AM +0200, Peter Zijlstra wrote:
> >
> > How insane?
>
> Anyway, the questino is; since int80 doesn't wipe the high regs, can we
> get away with the SYS*_compat things not doing that either and then all
> using the normal PUSH_AND_CLEAR_REGS without having to invent _COMPAT
> for that?
I'd rather not, clearing the register values on the stack is a good
thing as it gives attackers less control. In fact I wish we could do
that for the 64-bit syscalls, but alas, callee-saved registers and all.
--
Josh
next prev parent reply other threads:[~2022-04-09 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 22:38 [RFC][PATCH] x86: PUSH_AND_CLEAR_REGS_COMPAT Peter Zijlstra
2022-04-08 23:14 ` Peter Zijlstra
2022-04-09 2:00 ` Josh Poimboeuf [this message]
2022-04-10 15:20 ` Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220409020028.wfcwidlvg5rgwpki@treble \
--to=jpoimboe@redhat.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox