From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: bjorn.andersson@linaro.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] remoteproc: Don't bother checking the return value of debugfs_create*
Date: Mon, 11 Apr 2022 10:05:12 -0600 [thread overview]
Message-ID: <20220411160512.GB323343@p14s> (raw)
In-Reply-To: <20220329154616.58902-1-manivannan.sadhasivam@linaro.org>
On Tue, Mar 29, 2022 at 09:16:16PM +0530, Manivannan Sadhasivam wrote:
> DebugFS APIs are designed to return only the error pointers and not NULL
> in the case of failure. So these return pointers are safe to be passed on
> to the successive debugfs_create* APIs.
>
> Therefore, let's just get rid of the checks.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>
> Changes in v2:
>
> * Removed the error check of rproc_create_trace_file().
>
> drivers/remoteproc/remoteproc_core.c | 4 ----
> drivers/remoteproc/remoteproc_debugfs.c | 17 ++---------------
> 2 files changed, 2 insertions(+), 19 deletions(-)
>
Applied.
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 69f51acf235e..56c3f70723a9 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -684,10 +684,6 @@ static int rproc_handle_trace(struct rproc *rproc, void *ptr,
>
> /* create the debugfs entry */
> trace->tfile = rproc_create_trace_file(name, rproc, trace);
> - if (!trace->tfile) {
> - kfree(trace);
> - return -EINVAL;
> - }
>
> list_add_tail(&trace->node, &rproc->traces);
>
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index b5a1e3b697d9..2e2c4a31c154 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -386,16 +386,8 @@ void rproc_remove_trace_file(struct dentry *tfile)
> struct dentry *rproc_create_trace_file(const char *name, struct rproc *rproc,
> struct rproc_debug_trace *trace)
> {
> - struct dentry *tfile;
> -
> - tfile = debugfs_create_file(name, 0400, rproc->dbg_dir, trace,
> + return debugfs_create_file(name, 0400, rproc->dbg_dir, trace,
> &trace_rproc_ops);
> - if (!tfile) {
> - dev_err(&rproc->dev, "failed to create debugfs trace entry\n");
> - return NULL;
> - }
> -
> - return tfile;
> }
>
> void rproc_delete_debug_dir(struct rproc *rproc)
> @@ -411,8 +403,6 @@ void rproc_create_debug_dir(struct rproc *rproc)
> return;
>
> rproc->dbg_dir = debugfs_create_dir(dev_name(dev), rproc_dbg);
> - if (!rproc->dbg_dir)
> - return;
>
> debugfs_create_file("name", 0400, rproc->dbg_dir,
> rproc, &rproc_name_ops);
> @@ -430,11 +420,8 @@ void rproc_create_debug_dir(struct rproc *rproc)
>
> void __init rproc_init_debugfs(void)
> {
> - if (debugfs_initialized()) {
> + if (debugfs_initialized())
> rproc_dbg = debugfs_create_dir(KBUILD_MODNAME, NULL);
> - if (!rproc_dbg)
> - pr_err("can't create debugfs dir\n");
> - }
> }
>
> void __exit rproc_exit_debugfs(void)
> --
> 2.25.1
>
prev parent reply other threads:[~2022-04-11 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:46 [PATCH v2] remoteproc: Don't bother checking the return value of debugfs_create* Manivannan Sadhasivam
2022-04-11 16:05 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411160512.GB323343@p14s \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox