From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Leo Ruan <tingquan.ruan@cn.bosch.com>,
Mark Jonas <mark.jonas@de.bosch.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sasha Levin <sashal@kernel.org>,
airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 5.15 20/41] gpu: ipu-v3: Fix dev_dbg frequency output
Date: Mon, 11 Apr 2022 20:46:32 -0400 [thread overview]
Message-ID: <20220412004656.350101-20-sashal@kernel.org> (raw)
In-Reply-To: <20220412004656.350101-1-sashal@kernel.org>
From: Leo Ruan <tingquan.ruan@cn.bosch.com>
[ Upstream commit 070a88fd4a03f921b73a2059e97d55faaa447dab ]
This commit corrects the printing of the IPU clock error percentage if
it is between -0.1% to -0.9%. For example, if the pixel clock requested
is 27.2 MHz but only 27.0 MHz can be achieved the deviation is -0.8%.
But the fixed point math had a flaw and calculated error of 0.2%.
Before:
Clocks: IPU 270000000Hz DI 24716667Hz Needed 27200000Hz
IPU clock can give 27000000 with divider 10, error 0.2%
Want 27200000Hz IPU 270000000Hz DI 24716667Hz using IPU, 27000000Hz
After:
Clocks: IPU 270000000Hz DI 24716667Hz Needed 27200000Hz
IPU clock can give 27000000 with divider 10, error -0.8%
Want 27200000Hz IPU 270000000Hz DI 24716667Hz using IPU, 27000000Hz
Signed-off-by: Leo Ruan <tingquan.ruan@cn.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20220207151411.5009-1-mark.jonas@de.bosch.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/ipu-v3/ipu-di.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c
index 666223c6bec4..0a34e0ab4fe6 100644
--- a/drivers/gpu/ipu-v3/ipu-di.c
+++ b/drivers/gpu/ipu-v3/ipu-di.c
@@ -447,8 +447,9 @@ static void ipu_di_config_clock(struct ipu_di *di,
error = rate / (sig->mode.pixelclock / 1000);
- dev_dbg(di->ipu->dev, " IPU clock can give %lu with divider %u, error %d.%u%%\n",
- rate, div, (signed)(error - 1000) / 10, error % 10);
+ dev_dbg(di->ipu->dev, " IPU clock can give %lu with divider %u, error %c%d.%d%%\n",
+ rate, div, error < 1000 ? '-' : '+',
+ abs(error - 1000) / 10, abs(error - 1000) % 10);
/* Allow a 1% error */
if (error < 1010 && error >= 990) {
--
2.35.1
next prev parent reply other threads:[~2022-04-12 0:54 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 0:46 [PATCH AUTOSEL 5.15 01/41] drm/amd: Add USBC connector ID Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 02/41] btrfs: fix fallocate to use file_modified to update permissions consistently Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 03/41] btrfs: do not warn for free space inode in cow_file_range Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 04/41] drm/amdgpu: conduct a proper cleanup of PDB bo Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 05/41] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 06/41] drm/amd/display: fix audio format not updated after edid updated Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 07/41] drm/amd/display: FEC check in timing validation Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 08/41] drm/amd/display: Update VTEM Infopacket definition Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 09/41] drm/amdkfd: Fix Incorrect VMIDs passed to HWS Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 10/41] drm/amdgpu/vcn: improve vcn dpg stop procedure Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 11/41] drm/amdkfd: Check for potential null return of kmalloc_array() Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 12/41] Drivers: hv: vmbus: Deactivate sysctl_record_panic_msg by default in isolated guests Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 13/41] PCI: hv: Propagate coherence from VMbus device to PCI device Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 14/41] Drivers: hv: vmbus: Prevent load re-ordering when reading ring buffer Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 15/41] scsi: target: tcmu: Fix possible page UAF Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 16/41] scsi: lpfc: Fix queue failures when recovering from PCI parity error Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 17/41] scsi: ibmvscsis: Increase INITIAL_SRP_LIMIT to 1024 Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 18/41] net: micrel: fix KS8851_MLL Kconfig Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 19/41] ata: libata-core: Disable READ LOG DMA EXT for Samsung 840 EVOs Sasha Levin
2022-04-12 0:46 ` Sasha Levin [this message]
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 21/41] regulator: wm8994: Add an off-on delay for WM8994 variant Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 22/41] arm64: alternatives: mark patch_alternative() as `noinstr` Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 23/41] tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 24/41] net: axienet: setup mdio unconditionally Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 25/41] Drivers: hv: balloon: Disable balloon and hot-add accordingly Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 26/41] net: usb: aqc111: Fix out-of-bounds accesses in RX fixup Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 27/41] myri10ge: fix an incorrect free for skb in myri10ge_sw_tso Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 28/41] spi: cadence-quadspi: fix protocol setup for non-1-1-X operations Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 29/41] drm/amd/display: Enable power gating before init_pipes Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 30/41] drm/amd/display: Revert FEC check in validation Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 31/41] drm/amd/display: Fix allocate_mst_payload assert on resume Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 32/41] drbd: set QUEUE_FLAG_STABLE_WRITES Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 33/41] powerpc: Fix virt_addr_valid() for 64-bit Book3E & 32-bit Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 34/41] scsi: mpt3sas: Fail reset operation if config request timed out Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 35/41] scsi: mvsas: Add PCI ID of RocketRaid 2640 Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 36/41] scsi: megaraid_sas: Target with invalid LUN ID is deleted during scan Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 37/41] drivers: net: slip: fix NPD bug in sl_tx_timeout() Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 38/41] io_uring: zero tag on rsrc removal Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 39/41] io_uring: use nospec annotation for more indexes Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 40/41] arm64: Add part number for Arm Cortex-A78AE Sasha Levin
2022-04-12 0:46 ` [PATCH AUTOSEL 5.15 41/41] perf/imx_ddr: Fix undefined behavior due to shift overflowing the constant Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412004656.350101-20-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.jonas@de.bosch.com \
--cc=p.zabel@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=tingquan.ruan@cn.bosch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox