Re: [PATCH] uio: make MAX_UIO_MAPS & MAX_UIO_PORT_REGIONS configurable

Greg KH
2022-04-13T07:28:07Z

On Wed, Apr 13, 2022 at 10:11:37AM +0300, Ramon Fried wrote:
> MAX_UIO_MAPS and MAX_UIO_PORT_REGIONS are hard-coded to 5.
> This is not always sufficiant for some drivers.

Why not? What in-kernel drivers need more than this?

> Make the MAX_UIO_MAPS and MAX_UIO_PORT_REGIONS configurable by
> providing Kconfig int option with the defaut value of 5.

Spelling check?

>
> Signed-off-by: Ramon Fried <rfried.dev@gmail.com>
> ---
> drivers/uio/Kconfig | 14 ++++++++++++++
> include/linux/uio_driver.h | 4 ++--
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
> index 2e16c5338e5b..bc1fe83cec13 100644
> --- a/drivers/uio/Kconfig
> +++ b/drivers/uio/Kconfig
> @@ -13,6 +13,20 @@ menuconfig UIO
>
> if UIO
>
> +config UIO_MAX_MAPS
> + int "Maximum of memory nodes each uio device support(1-128)"

Space before "(" please.

> + range 1 128
> + default 5
> + help
> + Maximum memory mapping each uio device can support.

Any hints as to what this means in more detail?

> +
> +config UIO_MAX_PORT_REGIONS
> + int "Maximum of port regions each uio device support(1-128)"
> + range 1 128
> + default 5
> + help
> + Maximum port regions each uio device can support.

Again more detail please.

thanks,

greg k-h