public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: madvenka@linux.microsoft.com
To: mark.rutland@arm.com, broonie@kernel.org, jpoimboe@redhat.com,
	ardb@kernel.org, nobuta.keiya@fujitsu.com,
	sjitindarsingh@gmail.com, catalin.marinas@arm.com,
	will@kernel.org, jmorris@namei.org,
	linux-arm-kernel@lists.infradead.org,
	live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
	madvenka@linux.microsoft.com
Subject: [PATCH v14 6/7] arm64: Introduce arch_stack_walk_reliable()
Date: Wed, 13 Apr 2022 09:05:27 -0500	[thread overview]
Message-ID: <20220413140528.3815-7-madvenka@linux.microsoft.com> (raw)
In-Reply-To: <20220413140528.3815-1-madvenka@linux.microsoft.com>

From: "Madhavan T. Venkataraman" <madvenka@linux.microsoft.com>

Introduce arch_stack_walk_reliable() for ARM64. This works like
arch_stack_walk() except that it returns -EINVAL if the stack trace is not
reliable.

Until all the reliability checks are in place, arch_stack_walk_reliable()
may not be used by livepatch. But it may be used by debug and test code.

Signed-off-by: Madhavan T. Venkataraman <madvenka@linux.microsoft.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/kernel/stacktrace.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index eda8581f7dbe..8016ba0e2c96 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -383,3 +383,26 @@ noinline notrace void arch_stack_walk(stack_trace_consume_fn consume_entry,
 
 	unwind(&state, consume_entry, cookie);
 }
+
+/*
+ * arch_stack_walk_reliable() may not be used for livepatch until all of
+ * the reliability checks are in place in unwind_consume(). However,
+ * debug and test code can choose to use it even if all the checks are not
+ * in place.
+ */
+noinline int notrace arch_stack_walk_reliable(
+					stack_trace_consume_fn consume_entry,
+					void *cookie,
+					struct task_struct *task)
+{
+	struct unwind_state state;
+	bool reliable;
+
+	if (task == current)
+		unwind_init_from_caller(&state);
+	else
+		unwind_init_from_task(&state, task);
+
+	reliable = unwind(&state, consume_entry, cookie);
+	return reliable ? 0 : -EINVAL;
+}
-- 
2.25.1


  parent reply	other threads:[~2022-04-13 14:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f460a35f88195413bcf7305e5083480aab3ca858>
2022-04-13 14:05 ` [PATCH v14 0/7] arm64: Reorganize the unwinder and implement stack trace reliability checks madvenka
2022-04-13 14:05   ` [PATCH v14 1/7] arm64: Split unwind_init() madvenka
2022-05-10 18:15     ` Mark Brown
2022-05-18  5:20       ` Madhavan T. Venkataraman
2022-04-13 14:05   ` [PATCH v14 2/7] arm64: Copy the task argument to unwind_state madvenka
2022-05-10 18:18     ` Mark Brown
2022-05-18  5:21       ` Madhavan T. Venkataraman
2022-04-13 14:05   ` [PATCH v14 3/7] arm64: Make the unwind loop in unwind() similar to other architectures madvenka
2022-04-13 14:05   ` [PATCH v14 4/7] arm64: Introduce stack trace reliability checks in the unwinder madvenka
2022-04-13 14:05   ` [PATCH v14 5/7] arm64: Create a list of SYM_CODE functions, check return PC against list madvenka
2022-04-13 14:05   ` madvenka [this message]
2022-04-13 14:05   ` [PATCH v14 7/7] arm64: Select HAVE_RELIABLE_STACKTRACE madvenka
2022-04-13 14:11   ` [PATCH v14 0/7] arm64: Reorganize the unwinder and implement stack trace reliability checks Madhavan T. Venkataraman
2022-06-02 22:40   ` Madhavan T. Venkataraman
2022-06-14 17:48   ` Mark Brown
2022-06-15 19:19     ` Madhavan T. Venkataraman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220413140528.3815-7-madvenka@linux.microsoft.com \
    --to=madvenka@linux.microsoft.com \
    --cc=ardb@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=jmorris@namei.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nobuta.keiya@fujitsu.com \
    --cc=sjitindarsingh@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox