Re: [PATCH 06/34] drm/i915/gvt: move the gvt code into kvmgt.ko

Jason Gunthorpe
2022-04-11T18:43:16Z

On Mon, Apr 11, 2022 at 04:13:35PM +0200, Christoph Hellwig wrote:
> Instead of having an option to build the gvt code into the main i915
> module, just move it into the kvmgt.ko module. This only requires
> a new struct with three entries that the KVMGT modules needs to register
> with the main i915 module, and a proper list of GVT-enabled devices
> instead of global device pointer.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/gpu/drm/i915/Kconfig | 36 ++--
> drivers/gpu/drm/i915/Makefile | 2 +-
> drivers/gpu/drm/i915/gvt/Makefile | 5 +-
> drivers/gpu/drm/i915/gvt/gvt.c | 55 ++----
> drivers/gpu/drm/i915/gvt/gvt.h | 6 +-
> drivers/gpu/drm/i915/gvt/kvmgt.c | 14 +-
> drivers/gpu/drm/i915/gvt/mpt.h | 3 -
> drivers/gpu/drm/i915/i915_driver.c | 7 -
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/intel_gvt.c | 200 +++++++++++++-------
> drivers/gpu/drm/i915/intel_gvt.h | 17 +-
> drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 1 +
> 12 files changed, 193 insertions(+), 154 deletions(-)

There is a few things going on in here, I looked a few times and
didn't spot anything..

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason