From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>, Chao Gao <chao.gao@intel.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
m.szyprowski@samsung.com,
Wang Zhaoyang1 <zhaoyang1.wang@intel.com>,
Gao Liang <liang.gao@intel.com>,
Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH] dma-direct: avoid redundant memory sync for swiotlb
Date: Wed, 13 Apr 2022 18:44:15 +0200 [thread overview]
Message-ID: <20220413164415.GA31640@lst.de> (raw)
In-Reply-To: <4a993382-6a29-a0f4-4600-90ab60ad982a@arm.com>
On Wed, Apr 13, 2022 at 02:10:56PM +0100, Robin Murphy wrote:
> Are you sure? AFAICS swiotlb_map() does the right thing, and
> dma_direct_{sync,unmap} are working off the DMA address, which is that of
> the bounce slot when SWIOTLB is involved (not least, how would the
> is_swiotlb_buffer() checks work otherwise?)
Yeah, actually this should be fine.
prev parent reply other threads:[~2022-04-13 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 11:38 [PATCH] dma-direct: avoid redundant memory sync for swiotlb Chao Gao
2022-04-12 13:21 ` Chao Gao
2022-04-12 13:33 ` Robin Murphy
2022-04-13 1:02 ` Chao Gao
2022-04-13 4:59 ` Christoph Hellwig
2022-04-13 5:46 ` Chao Gao
2022-04-13 5:49 ` Christoph Hellwig
2022-04-13 13:10 ` Robin Murphy
2022-04-13 16:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413164415.GA31640@lst.de \
--to=hch@lst.de \
--cc=chao.gao@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kevin.tian@intel.com \
--cc=liang.gao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=zhaoyang1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox