From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, shengjiu.wang@nxp.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 0/2] remoteproc: elf: ignore PT_LOAD type segment with memsz as 0
Date: Wed, 13 Apr 2022 11:28:13 -0600 [thread overview]
Message-ID: <20220413172813.GB547134@p14s> (raw)
In-Reply-To: <20220413033038.1715945-1-peng.fan@oss.nxp.com>
On Wed, Apr 13, 2022 at 11:30:36AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> V2:
> Add R-b/A-b tag
> Drop inaccurate comment in patch 1
>
> i.MX DSP firmware has segments with PT_LOAD and memsz/filesz as zero.
> It is valid case the memsz set to zero according to elf spec:
> https://refspecs.linuxbase.org/elf/elf.pdf page 40
>
> So we could let remoteproc elf loader handle this case, then no
> duplicate code in imx dsp rproc driver
>
> Tested i.MX8MP DSP and M7 remoteproc
>
> Peng Fan (2):
> remoteproc: elf_loader: skip segment with memsz as zero
> remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments
>
> drivers/remoteproc/imx_dsp_rproc.c | 95 +---------------------
> drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
> 2 files changed, 2 insertions(+), 95 deletions(-)
>
I have applied this set but as I pointed out in the previous revision, it will
have to be backed-out if something breaks. Hopefully it won't get to that.
Thanks,
Mathieu
> --
> 2.25.1
>
prev parent reply other threads:[~2022-04-13 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 3:30 [PATCH V2 0/2] remoteproc: elf: ignore PT_LOAD type segment with memsz as 0 Peng Fan (OSS)
2022-04-13 3:30 ` [PATCH V2 1/2] remoteproc: elf_loader: skip segment with memsz as zero Peng Fan (OSS)
2022-04-13 3:30 ` [PATCH V2 2/2] remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments Peng Fan (OSS)
2022-04-13 17:28 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413172813.GB547134@p14s \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox