Re: [PATCH V2 0/2] remoteproc: elf: ignore PT_LOAD type segment with memsz as 0

Mathieu Poirier
2022-04-13T17:28:26Z

On Wed, Apr 13, 2022 at 11:30:36AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> V2:
> Add R-b/A-b tag
> Drop inaccurate comment in patch 1
>
> i.MX DSP firmware has segments with PT_LOAD and memsz/filesz as zero.
> It is valid case the memsz set to zero according to elf spec:
> https://refspecs.linuxbase.org/elf/elf.pdf page 40
>
> So we could let remoteproc elf loader handle this case, then no
> duplicate code in imx dsp rproc driver
>
> Tested i.MX8MP DSP and M7 remoteproc
>
> Peng Fan (2):
> remoteproc: elf_loader: skip segment with memsz as zero
> remoteproc: imx_dsp_rproc: use common rproc_elf_load_segments
>
> drivers/remoteproc/imx_dsp_rproc.c | 95 +---------------------
> drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
> 2 files changed, 2 insertions(+), 95 deletions(-)
>

I have applied this set but as I pointed out in the previous revision, it will
have to be backed-out if something breaks. Hopefully it won't get to that.

Thanks,
Mathieu

> --
> 2.25.1
>