From: Vladimir Oltean <olteanv@gmail.com>
To: Leo Li <leoyang.li@nxp.com>
Cc: "Z.Q. Hou" <zhiqiang.hou@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Xiaowei Bao <xiaowei.bao@nxp.com>
Subject: Re: [PATCH v3 1/8] arm64: dts: ls1028a: Add PCIe EP nodes
Date: Wed, 13 Apr 2022 21:22:07 +0300 [thread overview]
Message-ID: <20220413182207.chvdbqnmmm5vbz2b@skbuf> (raw)
In-Reply-To: <DU2PR04MB894975813DAC1043AAA23C5B8FEC9@DU2PR04MB8949.eurprd04.prod.outlook.com>
On Wed, Apr 13, 2022 at 06:03:37PM +0000, Leo Li wrote:
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:631.23-656.5: Warning
> > (unique_unit_address): /soc/pcie@3400000: duplicate unit-address (also
> > used in node /soc/pcie-ep@3400000)
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:670.23-695.5: Warning
> > (unique_unit_address): /soc/pcie@3500000: duplicate unit-address (also
> > used in node /soc/pcie-ep@3500000)
>
> This would be a common problem for all the layerscape PCIe controller.
> The controller can either work in RC mode or EP mode. The current
> binding of the controller defined two compatibles, one for RC and one
> for EP. Therefore the SoC dtsi will have two nodes with the same unit
> address one for EP one for RC. Fixing this probably requires
> comprehensive updates to the binding which breaks backward
> compatibility.
So we have to live with these warnings forever now?
How are the PCIe controllers configured for RC or EP mode? Via RCW?
Is dynamic configuration possible?
Can't U-Boot detect the operating mode from the RCW and fix up the
compatible string in case the controller is in endpoint mode?
next prev parent reply other threads:[~2022-04-13 18:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 9:32 [PATCH v3 0/8] ls1028a device tree update Li Yang
2021-12-14 9:32 ` [PATCH v3 1/8] arm64: dts: ls1028a: Add PCIe EP nodes Li Yang
2022-04-13 16:32 ` Vladimir Oltean
2022-04-13 18:03 ` Leo Li
2022-04-13 18:22 ` Vladimir Oltean [this message]
2022-04-13 18:38 ` Leo Li
2021-12-14 9:32 ` [PATCH v3 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source Li Yang
2021-12-14 9:32 ` [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes Li Yang
2022-04-13 16:33 ` Vladimir Oltean
2022-04-13 18:07 ` Leo Li
2022-04-13 18:23 ` Vladimir Oltean
2022-04-13 19:10 ` Leo Li
2022-07-28 9:33 ` Michael Walle
2022-08-16 9:04 ` Michael Walle
2022-08-17 20:20 ` Sean Anderson
2021-12-14 9:32 ` [PATCH v3 4/8] arm64: dts: ls1028a-rdb: reorder nodes to be alphabetic Li Yang
2021-12-16 10:01 ` Shawn Guo
2021-12-14 9:32 ` [PATCH v3 5/8] arm64: dts: ls1028a-rdb: enable pwm0 Li Yang
2021-12-14 9:32 ` [PATCH v3 6/8] arm64: dts: ls1028a-qds: move rtc node to the correct i2c bus Li Yang
2021-12-14 9:32 ` [PATCH v3 7/8] arm64: dts: ls1028a-qds: enable lpuart1 Li Yang
2021-12-14 9:32 ` [PATCH v3 8/8] arm64: dts: ls1028a-qds: add overlays for various serdes protocols Li Yang
2022-01-26 8:33 ` Shawn Guo
2022-01-26 8:55 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413182207.chvdbqnmmm5vbz2b@skbuf \
--to=olteanv@gmail.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=xiaowei.bao@nxp.com \
--cc=zhiqiang.hou@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox