Re: [PATCH v5 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML

Krzysztof Kozlowski
2022-04-13T19:31:25Z

On 13/04/2022 21:07, Corentin Labbe wrote:
> Convert rockchip-crypto to YAML.

Thank you for your patch. There is something to discuss/improve.

> +properties:
> + compatible:
> + enum:
> + - rockchip,rk3288-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 4
> +
> + clock-names:
> + maxItems: 4

This is not needed and dt_bindings_check should complain.

> + items:
> + const: aclk
> + const: hclk
> + const: sclk
> + const: apb_pclk
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + maxItems: 1

The same.

Best regards,
Krzysztof