From: Dan Carpenter <dan.carpenter@oracle.com>
To: Haowen Bai <baihaowen@meizu.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp()
Date: Fri, 15 Apr 2022 09:58:10 +0300 [thread overview]
Message-ID: <20220415065810.GQ3293@kadam> (raw)
In-Reply-To: <1650004767-27432-1-git-send-email-baihaowen@meizu.com>
On Fri, Apr 15, 2022 at 02:39:27PM +0800, Haowen Bai wrote:
> This commit message suggested by Dan Carpenter as below:
You don't need to add this. If you feel you must then put it below the
--- cut off line and it will be stored on lore.kernel.org until the end
of time.
> @@ -2292,8 +2298,8 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
> if (errcode) {
> ieee->softmac_stats.rx_auth_rs_err++;
> netdev_info(ieee->dev,
> - "Authentication response status code 0x%x",
> - errcode);
> + "Authentication response status code %d",
> + le16_to_cpu(errcode));
The error code is not a le16. It's just an int. The way to prevent
these kinds of issues in the future is to run Sparse with the endian
checking enabled.
https://lwn.net/Articles/205624/
regards,
dan carpenter
next prev parent reply other threads:[~2022-04-15 6:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:09 [PATCH V2] staging: rtl8192e: Fix signedness bug in rtllib_rx_assoc_resp() Haowen Bai
2022-04-15 5:22 ` Fabio M. De Francesco
2022-04-15 5:31 ` Dan Carpenter
2022-04-15 5:50 ` [PATCH V3] " Haowen Bai
2022-04-15 6:06 ` Fabio M. De Francesco
2022-04-15 6:10 ` Fabio M. De Francesco
2022-04-15 6:15 ` [PATCH V4] " Haowen Bai
2022-04-15 6:20 ` Dan Carpenter
2022-04-15 6:39 ` Haowen Bai
2022-04-15 6:58 ` Dan Carpenter [this message]
2022-04-15 7:21 ` Haowen Bai
2022-04-20 16:41 ` Greg Kroah-Hartman
2022-04-21 1:34 ` Haowen Bai
2022-04-21 8:09 ` kernel test robot
2022-04-21 8:21 ` [PATCH V5] " Haowen Bai
2022-04-21 16:22 ` Dan Carpenter
2022-04-18 1:48 ` [PATCH V4] " baihaowen
2022-04-15 6:18 ` [PATCH V3] " Dan Carpenter
2022-04-15 5:25 ` [PATCH V2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415065810.GQ3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=baihaowen@meizu.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox