From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F8CC433EF for ; Sat, 16 Apr 2022 05:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbiDPFow (ORCPT ); Sat, 16 Apr 2022 01:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbiDPFot (ORCPT ); Sat, 16 Apr 2022 01:44:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BC2DAC916; Fri, 15 Apr 2022 22:42:18 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4256768AFE; Sat, 16 Apr 2022 07:42:15 +0200 (CEST) Date: Sat, 16 Apr 2022 07:42:14 +0200 From: Christoph Hellwig To: Zhihao Cheng Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH] fs-writeback: Flush plug before next iteration in wb_writeback() Message-ID: <20220416054214.GA7386@lst.de> References: <20220415013735.1610091-1-chengzhihao1@huawei.com> <20220415063920.GB24262@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I think the root cause is fsync gets buffer head's lock without locking > corresponding page, fixing 'progess' and flushing plug are both > workarounds. So let's fix that.