From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF28C433EF for ; Mon, 18 Apr 2022 05:00:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236178AbiDRFC7 (ORCPT ); Mon, 18 Apr 2022 01:02:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbiDRFCz (ORCPT ); Mon, 18 Apr 2022 01:02:55 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A086DED6; Sun, 17 Apr 2022 22:00:17 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id E8D5068AA6; Mon, 18 Apr 2022 07:00:13 +0200 (CEST) Date: Mon, 18 Apr 2022 07:00:13 +0200 From: Christoph Hellwig To: Zhihao Cheng Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com Subject: Re: [PATCH] fs-writeback: Flush plug before next iteration in wb_writeback() Message-ID: <20220418050013.GA3372@lst.de> References: <20220415013735.1610091-1-chengzhihao1@huawei.com> <20220415063920.GB24262@lst.de> <20220416054214.GA7386@lst.de> <71acc295-3a5b-176d-a58e-2aa3ba7627d6@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71acc295-3a5b-176d-a58e-2aa3ba7627d6@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 16, 2022 at 04:41:35PM +0800, Zhihao Cheng wrote: > So, how about applying the safe and simple method(flush plug) for the time > being? As said before - if you flush everytime here the plug is basically useless and we could remove it. But it was added for a reason. So let's at least improve the accounting for the skipped writeback as suggested in your last mail.